From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753004AbcFNSpA (ORCPT ); Tue, 14 Jun 2016 14:45:00 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:26516 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751356AbcFNSo7 (ORCPT ); Tue, 14 Jun 2016 14:44:59 -0400 Subject: Re: [PATCH v2 1/2] liblockdep: Fix compile errors To: Vishal Thanki , linux-kernel@vger.kernel.org References: <1465901382-8216-1-git-send-email-vishalthanki@gmail.com> From: Sasha Levin Message-ID: <576050A6.2050202@oracle.com> Date: Tue, 14 Jun 2016 14:44:54 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1465901382-8216-1-git-send-email-vishalthanki@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/14/2016 06:49 AM, Vishal Thanki wrote: > diff --git a/tools/lib/lockdep/uinclude/linux/jhash.h b/tools/lib/lockdep/uinclude/linux/jhash.h > new file mode 100644 > index 0000000..348c6f4 > --- /dev/null > +++ b/tools/lib/lockdep/uinclude/linux/jhash.h > @@ -0,0 +1,175 @@ > +#ifndef _LINUX_JHASH_H Oh, we don't need to copy the whole thing. I was thinking about something like: diff --git a/tools/lib/lockdep/uinclude/linux/unaligned/packed_struct.h b/tools/lib/lockdep/uinclude/linux/unaligned/packed_struct.h new file mode 100644 index 0000000..7b204fc --- /dev/null +++ b/tools/lib/lockdep/uinclude/linux/unaligned/packed_struct.h @@ -0,0 +1,2 @@ +#include "../../../include/linux/unaligned/packed_struct.h" for both packed_struct.h and jhash.h. This was we get the advantage of having any fixes to those headers automatically go into liblockdep as well. Thanks, Sasha