From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932552AbcFNTJu (ORCPT ); Tue, 14 Jun 2016 15:09:50 -0400 Received: from lists.s-osg.org ([54.187.51.154]:52864 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932087AbcFNTJs (ORCPT ); Tue, 14 Jun 2016 15:09:48 -0400 Subject: Re: [PATCH] selftests/exec: Add Makefile to install list since exec test expect it To: Yannick Brosseau , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <1465929912-11516-1-git-send-email-scientist@fb.com> Cc: kernel-team@fb.com, Shuah Khan From: Shuah Khan Message-ID: <57605679.7080401@osg.samsung.com> Date: Tue, 14 Jun 2016 13:09:45 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1465929912-11516-1-git-send-email-scientist@fb.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/14/2016 12:45 PM, Yannick Brosseau wrote: > When running the execveat test once installed, the Makefile it not available and the > test fail. Bundling the Makefile file with the installed files fix that. Install is for installing kselftest binaries and run-time dependencies if any on a target system. It is not for being able to build it on the target. Bundling Makefile doesn't make sense. -- Shuah > > Signed-off-by: Yannick Brosseau > --- > tools/testing/selftests/exec/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/exec/Makefile b/tools/testing/selftests/exec/Makefile > index 4e400eb..d2be580 100644 > --- a/tools/testing/selftests/exec/Makefile > +++ b/tools/testing/selftests/exec/Makefile > @@ -1,6 +1,6 @@ > CFLAGS = -Wall > BINARIES = execveat > -DEPS = execveat.symlink execveat.denatured script subdir > +DEPS = execveat.symlink execveat.denatured script subdir Makefile > all: $(BINARIES) $(DEPS) > > subdir: >