Re: [PATCH v2 1/7] mm/compaction: split freepages without holding the zone lock

Vlastimil Babka
2016-06-06T15:19:19Z

On 06/03/2016 02:45 PM, Joonsoo Kim wrote:
> 2016-06-03 19:10 GMT+09:00 Vlastimil Babka <vbabka@suse.cz>:
>> On 05/26/2016 04:37 AM, js1304@gmail.com wrote:
>>>
>>> From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
>>>
>>> We don't need to split freepages with holding the zone lock. It will cause
>>> more contention on zone lock so not desirable.
>>>
>>> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
>>
>>
>> So it wasn't possible to at least move this code from compaction.c to
>> page_alloc.c? Or better, reuse prep_new_page() with some forged
>> gfp/alloc_flags? As we discussed in v1...
>
> Sorry for not mentioning that I did it as a separate patch,
> Please see below link which is the last one within this patchset.
>
> Link: http://lkml.kernel.org/r/1464230275-25791-7-git-send-email-iamjoonsoo.kim@lge.com

Ah I see. In that case,

Acked-by: Vlastimil Babka <vbabka@suse.cz>

> Thanks.
>