From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Thomas Gleixner <tglx@linutronix.de>,
Nicolas Pitre <nicolas.pitre@linaro.org>
Cc: shreyas@linux.vnet.ibm.com, linux-kernel@vger.kernel.org,
peterz@infradead.org, rafael@kernel.org,
vincent.guittot@linaro.org
Subject: Re: [PATCH V5] irq: Track the interrupt timings
Date: Tue, 14 Jun 2016 21:52:08 +0200 [thread overview]
Message-ID: <57606068.3000209@linaro.org> (raw)
In-Reply-To: <alpine.DEB.2.11.1606142010560.5839@nanos>
On 06/14/2016 08:11 PM, Thomas Gleixner wrote:
> On Tue, 14 Jun 2016, Nicolas Pitre wrote:
>> What about simply this:
>>
>> void __handle_timings(struct irq_desc *desc)
>> {
>> struct irq_timings *timings = this_cpu_ptr(desc->timings);
>> timings->w_index = (timings->w_index + 1) & IRQ_TIMINGS_MASK;
>> timings->values[timings->w_index] = local_clock();
>> }
>>
>> ?
>>
>> Then you could s/__handle_timings/__record_irq_time/ to better represent
>> what it does. And both the difference and the summing of squares could
>> be done upon entering idle instead.
>
> And make it part of the handle_timings() inline to avoid the function call.
Ah yes, nice !
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2016-06-14 19:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-14 16:33 [PATCH V5] irq: Track the interrupt timings Daniel Lezcano
2016-06-14 17:46 ` Nicolas Pitre
2016-06-14 18:11 ` Thomas Gleixner
2016-06-14 19:52 ` Daniel Lezcano [this message]
2016-06-14 20:10 ` [PATCH V6] " Daniel Lezcano
2016-06-14 20:38 ` Nicolas Pitre
2016-06-17 13:46 ` Thomas Gleixner
2016-06-17 17:16 ` [PATCH V7] " Daniel Lezcano
2016-06-23 8:41 ` Thomas Gleixner
2016-06-23 9:39 ` Daniel Lezcano
2016-06-23 10:12 ` Thomas Gleixner
2016-06-23 13:12 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57606068.3000209@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.pitre@linaro.org \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=shreyas@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox