From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753068AbcFNUWL (ORCPT ); Tue, 14 Jun 2016 16:22:11 -0400 Received: from mail-pf0-f170.google.com ([209.85.192.170]:32846 "EHLO mail-pf0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752015AbcFNUWI (ORCPT ); Tue, 14 Jun 2016 16:22:08 -0400 Subject: Re: [PATCH net-next v4 0/7] vmxnet3: upgrade to version 3 To: Shrikrishna Khare , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, pv-drivers@vmware.com References: <1465930348-92164-1-git-send-email-skhare@vmware.com> From: Florian Fainelli Message-ID: <5760676A.7070103@gmail.com> Date: Tue, 14 Jun 2016 13:22:02 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1465930348-92164-1-git-send-email-skhare@vmware.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/14/2016 11:52 AM, Shrikrishna Khare wrote: > This patchset upgrades vmxnet3 to version 3. > > Changes in v2: > - Following patch is updated. See that patch for details: > vmxnet3: add support for get_coalesce, set_coalesce ethtool > > Changes in v3: > - fix subject line to use vmxnet3: instead of Driver:Vmxnet3 > - resubmit when net-next is open > > Changes in v4: > - Following patch is updated. See that patch for details: > vmxnet3: add support for get_coalesce, set_coalesce ethtool You really need to improve your commit messages, because right now they are inexistent or too obvious to be of any value. A reviewer must be introduced to what code changes he/she is going to review next by looking at the diff and whether this will match or not the description that was provided in the commit message. -- Florian