From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751320AbcFNVbo (ORCPT ); Tue, 14 Jun 2016 17:31:44 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:21286 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750771AbcFNVbn (ORCPT ); Tue, 14 Jun 2016 17:31:43 -0400 Subject: Re: [PATCH 1/7] liblockdep: Fix undefined symbol prandom_u32 To: Ben Hutchings References: <20160614204437.GS7555@decadent.org.uk> <20160614204713.GT7555@decadent.org.uk> Cc: linux-kernel@vger.kernel.org From: Sasha Levin Message-ID: <576077B1.5040704@oracle.com> Date: Tue, 14 Jun 2016 17:31:29 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160614204713.GT7555@decadent.org.uk> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4Tqp8jRTwrh2AcuoMAbQKoKUBfKTUgdJh" X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --4Tqp8jRTwrh2AcuoMAbQKoKUBfKTUgdJh Content-Type: multipart/mixed; boundary="dG4KKLr7QPsFbCJl4b8LCpo5dVbEQHXs4" From: Sasha Levin To: Ben Hutchings Cc: linux-kernel@vger.kernel.org Message-ID: <576077B1.5040704@oracle.com> Subject: Re: [PATCH 1/7] liblockdep: Fix undefined symbol prandom_u32 References: <20160614204437.GS7555@decadent.org.uk> <20160614204713.GT7555@decadent.org.uk> In-Reply-To: <20160614204713.GT7555@decadent.org.uk> --dG4KKLr7QPsFbCJl4b8LCpo5dVbEQHXs4 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 06/14/2016 04:47 PM, Ben Hutchings wrote: > __lock_pin_lock() now calls prandom_u32() which is not defined in > liblockdep. __lock_pin_lock() and its caller lock_pin_lock() are dead > code in liblockdep, but we still need to provide a definition of > prandom_u32() in case lazy binding is disabled. >=20 > Fixes: e7904a28f533 ("locking/lockdep, sched/core: Implement a better .= =2E.") > Signed-off-by: Ben Hutchings > --- > tools/lib/lockdep/common.c | 6 ++++++ > 1 file changed, 6 insertions(+) >=20 > diff --git a/tools/lib/lockdep/common.c b/tools/lib/lockdep/common.c > index d1c89cc06f5f..405c17667c4d 100644 > --- a/tools/lib/lockdep/common.c > +++ b/tools/lib/lockdep/common.c > @@ -1,5 +1,6 @@ > #include > #include > +#include > #include > #include > #include > @@ -10,6 +11,11 @@ static __thread struct task_struct current_obj; > /* lockdep wants these */ > bool debug_locks =3D true; > bool debug_locks_silent; > +u32 prandom_u32(void) > +{ > + /* Used only by lock_pin_lock() which is dead code */ > + abort(); > +} I had to place this bit in lockdep.c rather than common.c, since lockdep.= c is the one building kernel/lockdep.c. Thanks, Sasha --dG4KKLr7QPsFbCJl4b8LCpo5dVbEQHXs4-- --4Tqp8jRTwrh2AcuoMAbQKoKUBfKTUgdJh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXYHeyAAoJEN6mb/eXdyzcJG4QAKNu/F5NSVJcMbLJUoV30XLY C0vEo2v+JYtS6z5xwg6YDwXjdHRHRmJFrGxUBkWS89SgZk+r/R3windHl5tQ/3Za ajZqZ9HIpfjdV3tp3XnTAm7cCGOlPrv5kWBFvPYVFNdVJ4EWeJlMffedX8yeNxtR nLC/00SMQZyV6fsyuV2+O2yXd08JMviDEwHXWlWH6prVdHQG5uGtc8YVm5FLTPS+ PJqefUdM8sahoTNMpS/gqZBd80N/qW09lQ31Len4KJGd8N1v0ytmmu7Pp8mpDttk IJuHOIzWbv6sOVT4kQgMvm7iCgUBQk+VZxcdm+ySUuXUEVxKIVIQ2z+rpU0Ndwzg 9Wc3B65rH781wc6ZqzHF0Y8aJ4WFP//5OAjdTEQRlBOfEUlvQ1ZCNpuhLg9KCX6r YY91mY+Bmf5zaj6+pezSNzOgbMnocKSI1I789Lo0ifE+jjPkTAN/n3RZktME5UkV FOijoI45YxCfb66BvQJc/42gzCuPU3NsfrqkjQfpiXSJYFFCTwjP3nlsZvHCg5UC Bo4CzZgjNyAB7F6QzUg1gLUKYJYW3ETpaL830DYKIMC0ADMYiuraGYBQQbdSkF2J Ei16OEtIAagU9ekLQDy0BJFmbiq6IJEAZ9A2YXwQq9Kzbj3QOWU6jYakhqsgbas/ 8E3292BrkNDVzEm2QBlf =6Eo8 -----END PGP SIGNATURE----- --4Tqp8jRTwrh2AcuoMAbQKoKUBfKTUgdJh--