From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753058AbcFOB53 (ORCPT ); Tue, 14 Jun 2016 21:57:29 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:38790 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751614AbcFOB51 (ORCPT ); Tue, 14 Jun 2016 21:57:27 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee691-f79196d000001483-62-5760b604c630 Content-transfer-encoding: 8BIT Message-id: <5760B604.10407@samsung.com> Date: Wed, 15 Jun 2016 10:57:24 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Roger Quadros , myungjoo.ham@samsung.com Cc: balbi@kernel.org, nm@ti.com, grygorii.strashko@ti.com, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH] extcon: palmas: Fix boot up state of VBUS when using GPIO detection References: <1465913075-30166-1-git-send-email-rogerq@ti.com> In-reply-to: <1465913075-30166-1-git-send-email-rogerq@ti.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprGIsWRmVeSWpSXmKPExsWyRsSkWJdlW0K4wb435hbH2p6wW6ycwmJx edccNovZS/pZLG43rmCzePPjLJNFzyMtB3aPTas62Tz6tqxi9Dh+YzuTx+dNcgEsUVw2Kak5 mWWpRfp2CVwZFyZoF+zmrGh/ldXA+I69i5GTQ0LARGL39I+sELaYxIV769m6GLk4hARWMEqs /DMFrujE1rUsEImljBL3FrUygyR4BQQlfky+B5Tg4GAWkJc4cikbJMwsoC4xad4iZoj6B4wS Wxb9ZwWp4RXQkDh9H2wZi4CqRMe2jWwgNpuAlsT+FzfYQEpEBSIkuk9UgpgiAtYSG777QAwv lehtDQcpFhaIkji07gvUlZMZJT5/62YESXAK2Enc37+DFSQhIXCMXeLa491QqwQkvk0+BHal hICsxKYDzBBfSUocXHGDZQKj2Cwkv8xC+GUWkl8WMDKvYhRNLUguKE5KLzLVK07MLS7NS9dL zs/dxAiMrtP/nk3cwXj/gPUhRgEORiUeXo6ahHAh1sSy4srcQ4ymQEdMZJYSTc4HxnBeSbyh sZmRhamJqbGRuaWZkjivjvTPYCGB9MSS1OzU1ILUovii0pzU4kOMTBycUg2Mh5h97PbuclWb OXdDX3nNsrw9QisOPXyy5Wvs32e7U986bTtmqul12f/giSuSmkests3cf+bMwTdp+7VWODyN sXpheO/ZrLTQpoa9MzVFvc9IfSiZz6P6Vkl7vsf0N4eX3T62eyvXxa05JzNiDzofeb1JKfSh SL9CWMnG68c1XbK0HzCYvpd9/VOJpTgj0VCLuag4EQB7cILPqQIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrMIsWRmVeSWpSXmKPExsVy+t9jAV2WbQnhBt+OG1kca3vCbrFyCovF 5V1z2CxmL+lnsbjduILN4s2Ps0wWPY+0HNg9Nq3qZPPo27KK0eP4je1MHp83yQWwRDUw2mSk JqakFimk5iXnp2TmpdsqeQfHO8ebmhkY6hpaWpgrKeQl5qbaKrn4BOi6ZeYAHaCkUJaYUwoU CkgsLlbSt8M0ITTETdcCpjFC1zckCK7HyAANJKxhzLgwQbtgN2dF+6usBsZ37F2MnBwSAiYS J7auZYGwxSQu3FvP1sXIxSEksJRR4t6iVmaQBK+AoMSPyfeAijg4mAXkJY5cygYJMwuoS0ya t4gZov4Bo8SWRf9ZQWp4BTQkTt9nBalhEVCV6Ni2kQ3EZhPQktj/4gYbSImoQIRE94lKEFNE wFpiw3cfiOGlEr2t4SDFwgJREofWfYE6ZjKjxOdv3YwgCU4BO4n7+3ewTmAUmIXktlkIt81C ctsCRuZVjBKpBckFxUnpuYZ5qeV6xYm5xaV56XrJ+bmbGMER/ExqB+PBXe6HGAU4GJV4eAsc E8KFWBPLiitzDzFKcDArifB6bgUK8aYkVlalFuXHF5XmpBYfYjQF+m4is5Rocj4wueSVxBsa m5gZWRqZG1oYGZsrifM+/r8uTEggPbEkNTs1tSC1CKaPiYNTqoFxyR+Rq1vy1dcsmNceXZB1 +O/cVXf3czA/CuTfbn/wMuPBq68a0/if5AVvU3ZM/cP+/Q//pAIW3vk/+Vx/vTu9cGHkKh23 HK5X/+WU94Wms6QIm03uuhg8c7Z9Cuuk90mFh10Zkut+hxxbW+r27cwDX8HAIz1eJ4NNHMoW 1JzPvLauvvGG/BYLJZbijERDLeai4kQAS66puvYCAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016년 06월 14일 23:04, Roger Quadros wrote: > If USB cable is connected prior to boot, we don't get any interrupts > so we must manually check the VBUS state and report it during probe. > If we don't do it then USB controller will never know that peripheral > cable was connected till the user unplugs and replugs the cable. > > Fixes: b7aad8e2685b ("extcon: palmas: Add the support for VBUS detection by using GPIO") > Signed-off-by: Roger Quadros > --- > drivers/extcon/extcon-palmas.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c > index 8b3226d..caff46c 100644 > --- a/drivers/extcon/extcon-palmas.c > +++ b/drivers/extcon/extcon-palmas.c > @@ -360,6 +360,8 @@ static int palmas_usb_probe(struct platform_device *pdev) > > palmas_enable_irq(palmas_usb); > /* perform initial detection */ > + if (palmas_usb->enable_gpio_vbus_detection) > + palmas_vbus_irq_handler(palmas_usb->gpio_vbus_irq, palmas_usb); > palmas_gpio_id_detect(&palmas_usb->wq_detectid.work); > device_set_wakeup_capable(&pdev->dev, true); > return 0; > Applied it. Thanks, Chanwoo Choi