From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752919AbcFOGLh (ORCPT ); Wed, 15 Jun 2016 02:11:37 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:23064 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750849AbcFOGLd (ORCPT ); Wed, 15 Jun 2016 02:11:33 -0400 X-IBM-Helo: d23dlp03.au.ibm.com X-IBM-MailFrom: shreyas@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org Date: Wed, 15 Jun 2016 11:41:12 +0530 From: Shreyas B Prabhu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.0 MIME-Version: 1.0 To: Michael Ellerman CC: ego@linux.vnet.ibm.com, mikey@neuling.org, benh@au1.ibm.com, linux-kernel@vger.kernel.org, maddy@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org Subject: Re: [v6, 07/11] powerpc/powernv: set power_save func after the idle states are initialized References: <3rTwNj07nPz9t1J@ozlabs.org> In-Reply-To: <3rTwNj07nPz9t1J@ozlabs.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16061506-0044-0000-0000-000001B48543 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16061506-0045-0000-0000-000004EE721C Message-Id: <5760F180.90107@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-06-15_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1606150069 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/15/2016 11:11 AM, Michael Ellerman wrote: > On Wed, 2016-08-06 at 16:54:27 UTC, "Shreyas B. Prabhu" wrote: >> pnv_init_idle_states discovers supported idle states from the >> device tree and does the required initialization. Set power_save >> function pointer only after this initialization is done > > This looks like a bug fix? Or is this not a concern in practice for some reason > (and if so what is that reason)? > This isn't a concern currently because, all powernv machines so far supported nap and nap does not need any initialization from kernel side. Thanks, Shreyas