From: Chanwoo Choi <cw00.choi@samsung.com>
To: Roger Quadros <rogerq@ti.com>, myungjoo.ham@samsung.com
Cc: balbi@kernel.org, nm@ti.com, grygorii.strashko@ti.com,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH] extcon: palmas: Fix boot up state of VBUS when using GPIO detection
Date: Wed, 15 Jun 2016 16:54:18 +0900 [thread overview]
Message-ID: <576109AA.8020601@samsung.com> (raw)
In-Reply-To: <5760FA16.5070008@ti.com>
On 2016년 06월 15일 15:47, Roger Quadros wrote:
> On 15/06/16 04:57, Chanwoo Choi wrote:
>> On 2016년 06월 14일 23:04, Roger Quadros wrote:
>>> If USB cable is connected prior to boot, we don't get any interrupts
>>> so we must manually check the VBUS state and report it during probe.
>>> If we don't do it then USB controller will never know that peripheral
>>> cable was connected till the user unplugs and replugs the cable.
>>>
>>> Fixes: b7aad8e2685b ("extcon: palmas: Add the support for VBUS detection by using GPIO")
>>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>>> ---
>>> drivers/extcon/extcon-palmas.c | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c
>>> index 8b3226d..caff46c 100644
>>> --- a/drivers/extcon/extcon-palmas.c
>>> +++ b/drivers/extcon/extcon-palmas.c
>>> @@ -360,6 +360,8 @@ static int palmas_usb_probe(struct platform_device *pdev)
>>>
>>> palmas_enable_irq(palmas_usb);
>>> /* perform initial detection */
>>> + if (palmas_usb->enable_gpio_vbus_detection)
>>> + palmas_vbus_irq_handler(palmas_usb->gpio_vbus_irq, palmas_usb);
>>> palmas_gpio_id_detect(&palmas_usb->wq_detectid.work);
>>> device_set_wakeup_capable(&pdev->dev, true);
>>> return 0;
>>>
>>
>> Applied it.
>
> Thanks. But this is a bug fix and must go in v4.7-rc
> as well as stable v4.6+.
OK. I'll send the pull request for this patch.
>
> Can you please add
>
> Cc: stable@vger.kernel.org # v4.6+
If we should add the 'stable@verger.kernel.org',
this patch should be sent to mailing list.
So, I think that you better to send this patch including stable mailing list.
And then, I'll send pull request which apply this patch to 4.7-rc.
Thanks,
Chanwoo Choi
next prev parent reply other threads:[~2016-06-15 7:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20160614140603epcas1p25c5893caf8e0f15d89fbc022d05f2a6f@epcas1p2.samsung.com>
2016-06-14 14:04 ` [PATCH] extcon: palmas: Fix boot up state of VBUS when using GPIO detection Roger Quadros
2016-06-15 1:57 ` Chanwoo Choi
2016-06-15 6:47 ` Roger Quadros
2016-06-15 7:54 ` Chanwoo Choi [this message]
2016-06-15 8:12 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=576109AA.8020601@samsung.com \
--to=cw00.choi@samsung.com \
--cc=balbi@kernel.org \
--cc=grygorii.strashko@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=nm@ti.com \
--cc=rogerq@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox