From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753343AbcFOKK3 (ORCPT ); Wed, 15 Jun 2016 06:10:29 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:29748 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753172AbcFOKKZ (ORCPT ); Wed, 15 Jun 2016 06:10:25 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8; format=flowed X-AuditID: cbfec7f4-f796c6d000001486-3e-5761298dd97b Content-transfer-encoding: 8BIT Message-id: <5761298C.9030005@samsung.com> Date: Wed, 15 Jun 2016 12:10:20 +0200 From: Jacek Anaszewski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8 To: =?UTF-8?B?TWljaGHFgiBLxJlwaWXFhA==?= Cc: Richard Purdie , Matthew Garrett , =?UTF-8?B?UGFsaSBSb2jDoXI=?= , Darren Hart , Bob Rodgers , Louis Davis , Jim Dailey , Alex Hung , linux-leds@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: Moving drivers/leds/dell-led.c to drivers/platform/x86 References: <20160613134942.GA2824@eudyptula.hq.kempniu.pl> In-reply-to: <20160613134942.GA2824@eudyptula.hq.kempniu.pl> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrPLMWRmVeSWpSXmKPExsVy+t/xq7q9monhBj/3yVlsORpl0bXQwOLZ k00sFouvXGG1uLxrDpvF1jfrGC1uzf3DZHH14WwWi4mnfzNZrN7zgtniysUNjBa7dz1ldeDx mNXQy+YxaeYMZo+ds+6ye2xeoeWx6HATs8ee+T9YPdbd+Mru8XmTXABHFJdNSmpOZllqkb5d AlfG608TmAo2ilb8a97M3sDYItjFyMkhIWAi8e7qNXYIW0ziwr31bCC2kMBSRonvFzVBbF4B QYkfk++xdDFycDALyEscuZQNEmYWMJN41LKOuYuRC6j8GaPE+i1z2CDqtSR6159nAbFZBFQl Ju89yAhiswkYSvx88ZoJxBYViJD4c3ofK4gtImAjcX7VPkaQQcwCC5kltnz5DVYkLOAs0XRs MTvEQdYSk/u3MoPYnEANrSvXM01gFJiF5L5ZCPfNQnLfAkbmVYyiqaXJBcVJ6bmGesWJucWl eel6yfm5mxgh0fJlB+PiY1aHGAU4GJV4eAscE8KFWBPLiitzDzFKcDArifC6KSaGC/GmJFZW pRblxxeV5qQWH2KU5mBREuedu+t9iJBAemJJanZqakFqEUyWiYNTqoGxeUvKlb3SCmWaYRyB 5x335j1PUpwgr1Op/cT31XTxjNkf7Vvjn3tela4zTjG19mZYdvj3lVlZn9+ekJi/qobJYF/f +kCbnSwxraZCOZdcdO2F33ConrvDky4hmneX4fOGXwZbL3JfsXpp+tZLyHWdpf26xZp/zCY8 PyV5aumer4KRSs9X/rykxFKckWioxVxUnAgALnFPJJICAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Michał, I have no objections. Best regards, Jacek Anaszewski On 06/13/2016 03:49 PM, Michał Kępień wrote: > Hi everyone, > > Back in January [1], while working on the dell-smbios module, I > suggested that the code present in drivers/leds/dell-led.c could be > moved to drivers/platform/x86 for coherency. I decided to revisit that > idea. > > dell-led consists of two major parts: > > - the part handling an "Activity LED" present in Dell Latitude 2100 > netbooks, introduced in 72dcd8d; it registers a LED device and uses > a special WMI interface to control its state, > > - the part exposing a "microphone mute LED interface", introduced in > db6d8cc; this interface is used by sound/pci/hda/dell_wmi_helper.c; > while the original implementation also used a WMI interface, it was > changed to use dell-smbios in cf0d7ea and 0c41a08. > > I believe both parts could (and should) be moved to drivers/platform/x86 > as drivers/platform/x86/dell-laptop.c already handles a bunch of LEDs > and drivers/leds/dell-led.c is the only dell-smbios user outside of > drivers/platform/x86. > > My question to you, the maintainers of the relevant drivers and > subsystems, is whether you would like to see such a move happen. I have > prepared a draft patch series which: > > - moves the "microphone mute LED interface" to dell-laptop.c, > effectively causing sound/pci/hda/dell_wmi_helper.c to depend on > CONFIG_DELL_LAPTOP instead of CONFIG_LEDS_DELL_NETBOOKS, > > - moves the "Activity LED" part to a new file, tentatively called > drivers/platform/x86/dell-wmi-led.c. > > Merging the "Activity LED" part with drivers/platform/x86/dell-wmi.c is > not really clean because dell-wmi handles a different GUID, which AFAIK > is not related in any way to the GUID used by dell-led. > > So, before I spam *three* subsystem mailing lists with a bunch of > patches, I would love to hear from the maintainers of both drivers/leds > and drivers/platform/x86 whether there are any arguments against such a > move. Meanwhile, I will keep polishing the patch series and if there is > no strong disagreement from any party involved, I will post the series > next week or so, so that we can discuss code and not just ideas. > > As a side note, if anyone reading this has access to a Dell device which > has an "Activity LED" and/or a "microphone mute LED" currently supported > by dell-led, I would love to hear from you as I do not have the hardware > needed to practically test the patch series I am working on. > > Looking forward to hearing from you, > > [1] https://www.spinics.net/lists/platform-driver-x86/msg08143.html >