From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161079AbcFOMA3 (ORCPT ); Wed, 15 Jun 2016 08:00:29 -0400 Received: from smtp-outbound-1.vmware.com ([208.91.2.12]:58975 "EHLO smtp-outbound-1.vmware.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161031AbcFOL76 (ORCPT ); Wed, 15 Jun 2016 07:59:58 -0400 Subject: Re: [PATCH] drm/vmwgfx: use *_32_bits() macros To: Paul Bolle , VMware Graphics , Sinclair Yeh , Thomas Hellstrom , Joe Perches , , References: <1457000770-2317-1-git-send-email-pebolle@tiscali.nl> <1460633540.2728.6.camel@tiscali.nl> <1460644444.19090.17.camel@perches.com> <1465979844.9515.11.camel@tiscali.nl> <20160615111134.GE1338@phenom.ffwll.local> From: Thomas Hellstrom Message-ID: <57614338.6070807@vmware.com> Date: Wed, 15 Jun 2016 13:59:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <20160615111134.GE1338@phenom.ffwll.local> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.113.170.11] X-ClientProxiedBy: EX13-CAS-002.vmware.com (10.113.191.52) To EX13-MBX-024.vmware.com (10.113.191.44) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/15/2016 01:11 PM, Daniel Vetter wrote: > On Wed, Jun 15, 2016 at 10:37:24AM +0200, Paul Bolle wrote: >> [Added Sinclair, Thomas, and "VMware Graphics".] >> >> On do, 2016-04-14 at 07:34 -0700, Joe Perches wrote: >>> On Thu, 2016-04-14 at 13:32 +0200, Paul Bolle wrote: >>>> On do, 2016-03-03 at 11:26 +0100, Paul Bolle wrote: >>>>> Use the upper_32_bits() macro instead of the four line equivalent that >>>>> triggers a GCC warning on 32 bits x86: >>>>> drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c: In function >>>>> 'vmw_cmdbuf_header_submit': >>>>> drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:297:25: warning: right >>>>> shift count >= width of type [-Wshift-count-overflow] >>>>> val = (header->handle >> 32); >>>>> ^ >>>>> >>>>> And use the lower_32_bits() macro instead of and-ing with a 32 bits >>>>> mask. >>>>> >>>>> Signed-off-by: Paul Bolle >>>>> --- >>>>> Note: compile tested only (I don't use any of vmware's products). >>>> The warning can still be seen on v4.6-rc3 for 32 bits x86. This patch >>>> applies cleanly to that rc. >>>> >>>> Has anyone had a chance to look at this patch, and perhaps even test >>>> it? >>> Test? Nope. Seems obviously correct. >> This warning still shows up when building v4.7-rc3 for 32 bits x86. >> >> Since my previous message an entry for this driver showed up in >> MAINTAINERS. So I'd guess Sinclair, Thomas, etc want me to resend this >> small patch. Is that correct? > Sounds more like maintainers asleep at the helm ;-) > > I've applied this to drm-misc, Sinclair can apply polish later on if he > wants to. > > Thanks, Daniel Thanks for applying this. FWIW, Reviewed-by: Thomas Hellstrom /Thomas