From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>, Thomas Gleixner <tglx@linutronix.de>
Cc: Vineet Gupta <vgupta@synopsys.com>, Noam Camus <noamc@ezchip.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clocksource: nps: fix nps_timer_init return value
Date: Wed, 15 Jun 2016 15:14:00 +0200 [thread overview]
Message-ID: <57615498.1060504@linaro.org> (raw)
In-Reply-To: <1465850493-3533419-1-git-send-email-arnd@arndb.de>
On 06/13/2016 10:41 PM, Arnd Bergmann wrote:
> The CLOCKSOURCE_OF_DECLARE macro ensures that the type of the init
> function matches the caller. In case of the new timer-nps driver,
> it doesn't match, so we get a warning:
>
> ../drivers/clocksource/timer-nps.c:97:208: error: comparison of distinct pointer types lacks a cast [-Werror]
> CLOCKSOURCE_OF_DECLARE(ezchip_nps400_clksrc, ezchip,nps400-timer,
>
> This changes the return type to match what the caller expects.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Thanks, I integrated this change with the series.
-- Daniel
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
prev parent reply other threads:[~2016-06-15 13:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 20:41 [PATCH] clocksource: nps: fix nps_timer_init return value Arnd Bergmann
2016-06-15 13:14 ` Daniel Lezcano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57615498.1060504@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=noamc@ezchip.com \
--cc=tglx@linutronix.de \
--cc=vgupta@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox