From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932869AbcFONOG (ORCPT ); Wed, 15 Jun 2016 09:14:06 -0400 Received: from mail-wm0-f48.google.com ([74.125.82.48]:36923 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932698AbcFONOC (ORCPT ); Wed, 15 Jun 2016 09:14:02 -0400 Subject: Re: [PATCH] clocksource: nps: fix nps_timer_init return value To: Arnd Bergmann , Thomas Gleixner References: <1465850493-3533419-1-git-send-email-arnd@arndb.de> Cc: Vineet Gupta , Noam Camus , linux-kernel@vger.kernel.org From: Daniel Lezcano Message-ID: <57615498.1060504@linaro.org> Date: Wed, 15 Jun 2016 15:14:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1465850493-3533419-1-git-send-email-arnd@arndb.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/13/2016 10:41 PM, Arnd Bergmann wrote: > The CLOCKSOURCE_OF_DECLARE macro ensures that the type of the init > function matches the caller. In case of the new timer-nps driver, > it doesn't match, so we get a warning: > > ../drivers/clocksource/timer-nps.c:97:208: error: comparison of distinct pointer types lacks a cast [-Werror] > CLOCKSOURCE_OF_DECLARE(ezchip_nps400_clksrc, ezchip,nps400-timer, > > This changes the return type to match what the caller expects. > > Signed-off-by: Arnd Bergmann > --- Thanks, I integrated this change with the series. -- Daniel -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog