From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753603AbcFOQv7 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 15 Jun 2016 12:51:59 -0400
Received: from devils.ext.ti.com ([198.47.26.153]:48101 "EHLO
	devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751269AbcFOQv5 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 15 Jun 2016 12:51:57 -0400
Subject: Re: [PATCH v3 2/2] reset: add a SYSCON based reset driver
To: "Andrew F. Davis" <afd@ti.com>, Philipp Zabel <p.zabel@pengutronix.de>,
        Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>
References: <20160601184125.20241-1-afd@ti.com>
 <20160601184125.20241-3-afd@ti.com>
CC: <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
From: Suman Anna <s-anna@ti.com>
Message-ID: <57618775.3000903@ti.com>
Date: Wed, 15 Jun 2016 11:51:01 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.8.0
MIME-Version: 1.0
In-Reply-To: <20160601184125.20241-3-afd@ti.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Andrew,

On 06/01/2016 01:41 PM, Andrew F. Davis wrote:
> Add a reset-controller driver for performing reset management of
> various devices present on the SoC, with the reset registers shared
> between devices in a common register memory space. This driver uses
> the syscon/regmap frameworks to actually implement the various reset
> functionalities needed by the reset consumer devices.
> 
> Signed-off-by: Andrew F. Davis <afd@ti.com>
> [s-anna@ti.com: add documentation, syscon name change]
> Signed-off-by: Suman Anna <s-anna@ti.com>
> ---
>  drivers/reset/Kconfig        |  10 ++
>  drivers/reset/Makefile       |   1 +
>  drivers/reset/reset-syscon.c | 289 +++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 300 insertions(+)
>  create mode 100644 drivers/reset/reset-syscon.c
> 
> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> index 0b2733d..73072e2 100644
> --- a/drivers/reset/Kconfig
> +++ b/drivers/reset/Kconfig
> @@ -15,5 +15,15 @@ menuconfig RESET_CONTROLLER
>  config RESET_OXNAS
>  	bool
>  
> +config SYSCON_RESET
> +	tristate "SYSCON Reset Driver"
> +	depends on RESET_CONTROLLER

Please add a depends on HAS_IOMEM here that you seem to have missed from
our local patches.

regards
Suman

> +	select MFD_SYSCON
> +	help
> +	  This enables the reset driver support for devices with memory-mapped
> +	  reset registers as part of a syscon device node. If you wish to use
> +	  the reset framework for such memory-mapped devices, say Y here.
> +	  Otherwise, say N.
> +