From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932921AbcFOQxP (ORCPT ); Wed, 15 Jun 2016 12:53:15 -0400 Received: from bear.ext.ti.com ([198.47.19.11]:43139 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753083AbcFOQxM (ORCPT ); Wed, 15 Jun 2016 12:53:12 -0400 Subject: Re: [PATCH v3 2/2] reset: add a SYSCON based reset driver To: Suman Anna , Philipp Zabel , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala References: <20160601184125.20241-1-afd@ti.com> <20160601184125.20241-3-afd@ti.com> <57618775.3000903@ti.com> CC: , From: "Andrew F. Davis" Message-ID: <576187C7.3020901@ti.com> Date: Wed, 15 Jun 2016 11:52:23 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <57618775.3000903@ti.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/15/2016 11:51 AM, Suman Anna wrote: > Hi Andrew, > > On 06/01/2016 01:41 PM, Andrew F. Davis wrote: >> Add a reset-controller driver for performing reset management of >> various devices present on the SoC, with the reset registers shared >> between devices in a common register memory space. This driver uses >> the syscon/regmap frameworks to actually implement the various reset >> functionalities needed by the reset consumer devices. >> >> Signed-off-by: Andrew F. Davis >> [s-anna@ti.com: add documentation, syscon name change] >> Signed-off-by: Suman Anna >> --- >> drivers/reset/Kconfig | 10 ++ >> drivers/reset/Makefile | 1 + >> drivers/reset/reset-syscon.c | 289 +++++++++++++++++++++++++++++++++++++++++++ >> 3 files changed, 300 insertions(+) >> create mode 100644 drivers/reset/reset-syscon.c >> >> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig >> index 0b2733d..73072e2 100644 >> --- a/drivers/reset/Kconfig >> +++ b/drivers/reset/Kconfig >> @@ -15,5 +15,15 @@ menuconfig RESET_CONTROLLER >> config RESET_OXNAS >> bool >> >> +config SYSCON_RESET >> + tristate "SYSCON Reset Driver" >> + depends on RESET_CONTROLLER > > Please add a depends on HAS_IOMEM here that you seem to have missed from > our local patches. > Will add for v4. Thanks, Andrew