From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753708AbcFOScj (ORCPT ); Wed, 15 Jun 2016 14:32:39 -0400 Received: from mail-lf0-f65.google.com ([209.85.215.65]:33743 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751739AbcFOScg (ORCPT ); Wed, 15 Jun 2016 14:32:36 -0400 Subject: Re: [PATCH 4/5] nvmet-rdma: add a NVMe over Fabrics RDMA target driver To: Steve Wise , "'Sagi Grimberg'" , "'Christoph Hellwig'" , axboe@kernel.dk, keith.busch@intel.com, sean.hefty@intel.com References: <1465248215-18186-1-git-send-email-hch@lst.de> <1465248215-18186-5-git-send-email-hch@lst.de> <5756B75C.9000409@lightbits.io> <057a01d1c2a3$3082eec0$9188cc40$@opengridcomputing.com> <00f501d1c657$483a74e0$d8af5ea0$@opengridcomputing.com> <00f701d1c658$efd720d0$cf856270$@opengridcomputing.com> Cc: linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, "'Armen Baloyan'" , "'Jay Freyensee'" , "'Ming Lin'" , linux-rdma@vger.kernel.org From: Sagi Grimberg Message-ID: <57619F3E.6070903@gmail.com> Date: Wed, 15 Jun 2016 21:32:30 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <00f701d1c658$efd720d0$cf856270$@opengridcomputing.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Looking at rdma_destroy_id(), I think it is invalid to call it from the event > handler: ... > > So I withdraw my comment about nvmet. I think the code is fine as-is. The 2nd > reject results in a no-op since the connection request was rejected by nvmet. I was just catching up on this after a short vacation, just what I was about to comment, thanks Steve :)