From: Shuah Khan <shuahkh@osg.samsung.com>
To: Yannick Brosseau <scientist@fb.com>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: kernel-team@fb.com, Shuah Khan <shuahkh@osg.samsung.com>
Subject: Re: [PATCH] selftests/exec: Makefile is a run-time dependency, add it to the install list
Date: Wed, 15 Jun 2016 14:11:34 -0600 [thread overview]
Message-ID: <5761B676.70603@osg.samsung.com> (raw)
In-Reply-To: <1466015772-4081-1-git-send-email-scientist@fb.com>
On 06/15/2016 12:36 PM, Yannick Brosseau wrote:
> The execveat test try to exec the Makefile file and expect an EACCES results. When running
> the test in the installed destination it would fail with ENOENT since the file is
> not there.
> Add Makefile to the TEST_FILES list so it's copied at install time.
>
> Signed-off-by: Yannick Brosseau <scientist@fb.com>
> ---
> tools/testing/selftests/exec/Makefile | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/exec/Makefile b/tools/testing/selftests/exec/Makefile
> index 4e400eb..d430060 100644
> --- a/tools/testing/selftests/exec/Makefile
> +++ b/tools/testing/selftests/exec/Makefile
> @@ -18,7 +18,8 @@ execveat.denatured: execveat
> $(CC) $(CFLAGS) -o $@ $^
>
> TEST_PROGS := execveat
> -TEST_FILES := $(DEPS)
> +# Makefile is a run-time dependency, since it's accessed by the execveat test
> +TEST_FILES := $(DEPS) Makefile
>
> include ../lib.mk
>
>
Thanks. Applied and queued for the next rc in linux-kselftest fixes branch
-- Shuah
prev parent reply other threads:[~2016-06-15 20:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 18:36 [PATCH] selftests/exec: Makefile is a run-time dependency, add it to the install list Yannick Brosseau
2016-06-15 20:11 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5761B676.70603@osg.samsung.com \
--to=shuahkh@osg.samsung.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=scientist@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox