From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161172AbcFOULo (ORCPT ); Wed, 15 Jun 2016 16:11:44 -0400 Received: from lists.s-osg.org ([54.187.51.154]:33694 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161112AbcFOULg (ORCPT ); Wed, 15 Jun 2016 16:11:36 -0400 Subject: Re: [PATCH] selftests/exec: Makefile is a run-time dependency, add it to the install list To: Yannick Brosseau , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <1466015772-4081-1-git-send-email-scientist@fb.com> Cc: kernel-team@fb.com, Shuah Khan From: Shuah Khan Message-ID: <5761B676.70603@osg.samsung.com> Date: Wed, 15 Jun 2016 14:11:34 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1466015772-4081-1-git-send-email-scientist@fb.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/15/2016 12:36 PM, Yannick Brosseau wrote: > The execveat test try to exec the Makefile file and expect an EACCES results. When running > the test in the installed destination it would fail with ENOENT since the file is > not there. > Add Makefile to the TEST_FILES list so it's copied at install time. > > Signed-off-by: Yannick Brosseau > --- > tools/testing/selftests/exec/Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/exec/Makefile b/tools/testing/selftests/exec/Makefile > index 4e400eb..d430060 100644 > --- a/tools/testing/selftests/exec/Makefile > +++ b/tools/testing/selftests/exec/Makefile > @@ -18,7 +18,8 @@ execveat.denatured: execveat > $(CC) $(CFLAGS) -o $@ $^ > > TEST_PROGS := execveat > -TEST_FILES := $(DEPS) > +# Makefile is a run-time dependency, since it's accessed by the execveat test > +TEST_FILES := $(DEPS) Makefile > > include ../lib.mk > > Thanks. Applied and queued for the next rc in linux-kselftest fixes branch -- Shuah