From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933454AbcFOU1N (ORCPT ); Wed, 15 Jun 2016 16:27:13 -0400 Received: from lists.s-osg.org ([54.187.51.154]:33766 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753117AbcFOU1H (ORCPT ); Wed, 15 Jun 2016 16:27:07 -0400 Message-ID: <5761BA18.9070500@osg.samsung.com> Date: Wed, 15 Jun 2016 21:27:04 +0100 From: Luis de Bethencourt User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 MIME-Version: 1.0 To: Rithvik Patibandla , forest@alittletooquiet.net CC: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, habdul@visteon.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging:vt6656:card.c:Fix comment block issue References: <20160611200858.GA21973@rithvik-IdeaPad> In-Reply-To: <20160611200858.GA21973@rithvik-IdeaPad> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/06/16 21:08, Rithvik Patibandla wrote: > Fix "Block comments use * on subsequent lines" and "Block comments use > */ on trailing lines" warnings thrown by checkpatch.pl > > Signed-off-by: Rithvik Patibandla > --- > drivers/staging/vt6656/card.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/vt6656/card.c b/drivers/staging/vt6656/card.c > index a382fc6..607834c 100644 > --- a/drivers/staging/vt6656/card.c > +++ b/drivers/staging/vt6656/card.c > @@ -47,7 +47,8 @@ > #include "usbpipe.h" > > /* const u16 cwRXBCNTSFOff[MAX_RATE] = > - {17, 34, 96, 192, 34, 23, 17, 11, 8, 5, 4, 3}; */ > + * {17, 34, 96, 192, 34, 23, 17, 11, 8, 5, 4, 3}; > + */ > > static const u16 cwRXBCNTSFOff[MAX_RATE] = { > 192, 96, 34, 17, 34, 23, 17, 11, 8, 5, 4, 3 > Hi Rithvik, The following warning is indeed fixed :) This patch looks good. WARNING: Block comments use * on subsequent lines #50: FILE: drivers/staging/vt6656/card.c:50: +/* const u16 cwRXBCNTSFOff[MAX_RATE] = + {17, 34, 96, 192, 34, 23, 17, 11, 8, 5, 4, 3}; */ There are 32 other checks that checkpatch complains about in that file. Please send fixes for those as well. Luis