From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753748AbcFOUsW (ORCPT ); Wed, 15 Jun 2016 16:48:22 -0400 Received: from mail-bn1on0096.outbound.protection.outlook.com ([157.56.110.96]:36746 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752559AbcFOUsU (ORCPT ); Wed, 15 Jun 2016 16:48:20 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Christian.Koenig@amd.com; Subject: Re: [PATCH] amdgpu: use NULL instead of 0 for pointer To: Arnd Bergmann , Alex Deucher References: <20160615201531.3346929-1-arnd@arndb.de> CC: David Airlie , Rex Zhu , , From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <5761BB7A.8080209@amd.com> Date: Wed, 15 Jun 2016 22:32:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <20160615201531.3346929-1-arnd@arndb.de> Content-Type: text/plain; charset="iso-8859-15"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [2a02:908:1251:a381:8573:fc89:b199:b441] X-ClientProxiedBy: VI1PR06CA0016.eurprd06.prod.outlook.com (10.162.116.154) To BY2PR1201MB0919.namprd12.prod.outlook.com (10.164.167.15) X-MS-Office365-Filtering-Correlation-Id: abd70c96-2043-4c12-0960-08d3955c469a X-Microsoft-Exchange-Diagnostics: 1;BY2PR1201MB0919;2:ZUBla76tY8DOJQgakDrs9lKJac4gEAyJYrm6KWrK3yS9MJ91J4nkdqaz1DxdbQT0IqVwHWdHRdsf0OujfGFSJX7B8/JCJPZKkPyE8tto+KC7r5yf7mIIc7xlzPdwW/TdyY//VEoNQnxc3qiEgvyaYADuyn/CnsFdwd5W5Yy/6LvyVNFgqxCxv5c4LfA29A6o;3:l7X4cJZic+4UBkmjELnL0Pxi1IOQmYj8iQDeN75hNES+SxPyCX0/GChmwHZPDCQkgXITEt1c7zJctVZ+/lT+DEayNODo6gqZ+afFJ2rJTPMYUJOLVpzQl+9l8tr/l5mk X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR1201MB0919; X-Microsoft-Exchange-Diagnostics: 1;BY2PR1201MB0919;25:0CbnRafrmlk40H4CtVzxAeTQLkwjMgsmzaJICFAFmIB6k2US1yy1KgaeXW3KqLiO9nPOpeqBJUVaiu8GBdabqidCmAUnEdrmKu3RpJbd4hC1zqxY8ACrWdDVDV/xqhQgLsH+P0KRj3eFIySgeKQc3sPJYdknDf+EEZu0efZSyxxMUg8YMdi2A6daRtnOzay8R+RyJIB4Xzh0TKy6GLMEf/UMKRPBZdzXuvjeZ+1wLhDun0/M+9vppDkSXu3KVv1ycVONSK7ZypMwwmwVLGm6sg1oFnimwddmBB7T6TKVwCRu3DDmUVQGF8nHnU/Jwv5FSDNZ0F1bEi17ecVCBB+sAZKOtBQAcNvIJ8nkg7ddoF9khnkuCjkRScCpNQ7UfYEEGfaECJaNoy5orf+kaxXNGYkuzlVrRcaZw0brfTdkdHg5GGxjueNUD2D+f+lsjNdQzAdV6i5XQZkN8I55cbGh6IIoWY8FUjE8LuVVA8CftIqOu1WutwzsIa0QnzJRJU/9WNDYj0sX9lJuZ9HdksQePZVhYTUi9Es3R2FvysKT4jfR1VboW9MdlNGdTAozjvxFlGs0gw8nDeSmBvxps0XoQBuvSgjW+QSIwmhtmitnbk1r5166F6buPW1WMxmg43LRn4Biim+eTCsWC7isGiWC/teRIQeCUpnzA4ls/rLx3SiE/A3dUrLtv77cOGTcW/9sNWkqQALPt8Rd3mZTxXu2Kwv276zXHIYrbr0eS7H4cVJixzy/EM4sAF4KYTV12730VrdmdidnhI08KwkD9rkTBA== X-Microsoft-Exchange-Diagnostics: 1;BY2PR1201MB0919;20:I4Uil/tJ62qX5s0oQZktvSzS5DbVrNEjnNauy+V5XI5jtS+thvCJY2476YvOcasrnxqN2GlsyjPpqkTwW2KT2kBd7CvbyGpSwi4m5w9CSeIQsPWJO/vsNwSd34/+aJ5z5IFl4pUh66LtoabV29LWsnTqc5v3OXslZZWC2klkOPcJB4yXvEemOr2J/pBe8yn+PBy89yECg37E6wb74D4cRwQwcyg/KaKL58USQhR4u35xh4mn/sTkLbn/Ez9JNVaizI9f9gqjSfR2cggBL3M0kRIjTQZyHB+ERbdWa5HTXMYGH3/9akguyBiwrKGtYcFtDFKhKjrStT+LH4myiMqQX2MBAjnKBXQyMQl/+a9RImjatmZEKTD8Qbqx0wsQmnyZibE3ed2cvtQD9NuvIVRTLx3YfCnSvlHsf5mtXVR4aEU+p79cIaYPoEx3gMViM20ByeNPB1pn/b2kDkcGlIZh/OQ/LF8VWCcelPaBt1zL9vzYs7RxMxhIkpSr5A78fubZ;4:GiId+XrhZoFIsEztc3mg0lBW4sohhhMSR+d/Xzitl1a2qnxF3Znmy7P04y0LTU2IWi6Qx8MHvPnFS5CNLVjlhNEfVK0Y8ZM86Smyu+dDN/J3lW4gRKauluc6MYrNJlSklt08tKEbafdudALAfufgKCeq9YdGl6psXRqFPw7E29058kGNYhXM3FLgrPxEL0lJkR/8krJ1ArW18VLL7vMomPgBs7B/xBW1RJ6HlOzP/vTSAFNBn1rXrYKqeTfFx44w/QYaJ3fR53e7uGB67Ud/aNiEUySu/JHra/PSEOtesiXN+BJtfBA08pXWb037V8yVQHzJnJuaZoOfO4rsEMX5C+p2gSf3Umc4JPCfmbCVbqEe64j2rWohjp/L/TAVKXZzjj141VlcfngHSpbLQxisVK6+M+DbddO1bc8DiCRLQWQ= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026);SRVR:BY2PR1201MB0919;BCL:0;PCL:0;RULEID:;SRVR:BY2PR1201MB0919; X-Forefront-PRVS: 09749A275C X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(189002)(199003)(4001350100001)(54356999)(50986999)(8676002)(101416001)(87266999)(81156014)(81166006)(76176999)(65816999)(47776003)(586003)(105586002)(36756003)(106356001)(1706002)(59896002)(50466002)(68736007)(97736004)(33656002)(77096005)(5001770100001)(6116002)(83506001)(189998001)(64126003)(19580395003)(19580405001)(5008740100001)(80316001)(86362001)(2950100001)(2906002)(65806001)(65956001)(42186005)(23756003)(2870700001)(4326007)(92566002)(5004730100002)(3826002);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2PR1201MB0919;H:[IPv6:2a02:908:1251:a381:8573:fc89:b199:b441];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;CAT:NONE;LANG:en;CAT:NONE; X-Microsoft-Exchange-Diagnostics: =?iso-8859-15?Q?1;BY2PR1201MB0919;23:Ah/tKiEITq0T9Ne7bK9p5rqESgIXCm7ncdtH?= =?iso-8859-15?Q?Nvqa5UJJSqOPzJu079ZLAj7nwwq1BRorlzPsqXccjzRFm/TjvzlpEJAeN?= =?iso-8859-15?Q?7YUeTxPGdXIib4F4zOa/Rs5lswqM0jtv23oO3d+xNXp00SOP7Ob5bDn0A?= =?iso-8859-15?Q?qRm9BphKFMuXoJHoKhIOvfl5Fy3GbtlYhsGwhpBs378RAJPJJp7ktNQyJ?= =?iso-8859-15?Q?y/J7rPVnB42/4APmemzGiGQ5ozR/zeMTPa6sG35yCaJyq2ojz3s+gOQvg?= =?iso-8859-15?Q?rnn9hmuTMh/OZIY8NCRI94JaQ5ny+xlBm2jFsSOGynku2HHSjGvZ3kuzp?= =?iso-8859-15?Q?64nQBq7JGCFmBeAMdOOWCDMY4+uB99HYOO4O1AcMnNH+JPkAGTalqiStz?= =?iso-8859-15?Q?/MMJnN8yeDYHzXKWBBJLS++lsKMegOhAWOfZoR5h16FMX1R4um61b6rf8?= =?iso-8859-15?Q?G1mud9HSryWN7upLJW3ORJ/8L4KJzfUaHcqt6Evh3Kkm5dJMlrM93L6Qa?= =?iso-8859-15?Q?5les8g4Vf+/YpPc0ppFOrj15HaQo28eHGoLWQN17+u+2tDe6t8JKeGC6l?= =?iso-8859-15?Q?h3Hx1BlD8DlBZ4finy88hU8Jf6E3VVLIOy4AVW2cyBSe1sXw7s3XxL7PU?= =?iso-8859-15?Q?uCzK0WW+kE+r6PF4d94vopqaeewtMBx0I07uhmrUpreljwNDkZoejoYGJ?= =?iso-8859-15?Q?EUSCYTLVOS62yXUTxqGvl+sdIfdPu8iGr5t7zyiIDb+1S7/J5y7bnONgx?= =?iso-8859-15?Q?z2+dM177xgJUygILitEHJOIArHSw8AfmBq35WPjCLasnPau+ImWbKph7l?= =?iso-8859-15?Q?jxtmBkEy1i5gNfe3wHRf/gQ9XmiU//1Jw3q39vnziAXUnG3FjRKEDBjr8?= =?iso-8859-15?Q?MOwZ7JckIYYtqxJ5slwu2mMy+zmezmNS4uUa/RE33MW16Q4CbqL+HoGFI?= =?iso-8859-15?Q?+PmK49mVM5vKPWkTt5mEmoz1K2solV0WA0wU/HVoQDwwnV3kwEMBVJ4xs?= =?iso-8859-15?Q?zirTbzkjs24Fowk1Z9sNKkwxzyDfQ4oEEp6vlevUQzcH0a6C7zqTLYTD6?= =?iso-8859-15?Q?XEvdnguSp1ooTtHNiiPnaRvJfm3Gr/g12S+fFUmspUicT5w/puZ+UlveS?= =?iso-8859-15?Q?EDYW/KZh+hwrangMEpAOsq+5K1brXVLVbU1O2XBAiZWzTA9LB89OW7HXG?= =?iso-8859-15?Q?KLu2Dec/mt2fUN9758H1tIaSEOeccVy156rQXCpEY165GQbDZE6LOQiSI?= =?iso-8859-15?Q?ioDKe7N1CYYio+5xEs9EEuH7eZOhFvTIBBqkWVkU7er3PeHKtLzmPs291?= =?iso-8859-15?Q?6KPkg=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BY2PR1201MB0919;6:Sxh21Xg6fbfirEdm1WoMKQoi0yNGbke/oIe9rIykw2ORmoROD26PsqPIPJOa7cdPjGj0D5iAVSZBmK0VzqVF0KMPVqkUYd1jLY0G0tzkSzQ6HWE4NhPAe1p15bUFoerC1AbvmJAzyGFDokU1eyBV9oY+m7jA0RNg4MSoKqCzViaYama60SeQnUGENdEyaAB2wkXv7wKt9K7TsOPQbP8c6L9CLQ7ZV9gLkFGj46E0+ekWMqf4SsFfRVAOd1Zt47ehcDEDuIYRSK9bqmdBkMb6Sc48nHKN3wEJ8mTPvNiduxkPKGYGSXmdPHIja/PLehRC;5:PQ/KbRV1Uxt1SPgP2dI03ynqK8G2+7icbdCtisjZZWMVWzH7xLfvtMlYr0U+0L4JHakRzF+hcmUf3VvZKpJwQWV91arEiOwb19GTBt2Shk2R4EHahacFQOJXRgwN3WaDKxwrvdlUvW8Qebp0iTgDNg==;24:fQoocg8Pfnx7oyNlPi/dTpI9pyAdi+2z7XovyqLjdkY1bCLZxrGHQwc5SAgS83vdnMBx1i1xZhDqwRKc9OHyZ6JSVPJAl80gcj/BVDTaJ9k=;7:XSb3EIzHT6tE1V2+7BAAduniu9h1esjIb6WJbtEFZrMZxWTErGUOeZsql7zT2ah5HVUTsCM3vUyo6tWTvI53mgFDs8mhsaC1aZC+w4g1TtbR3AeVovfcKWgtTngNJ4A9f3la7479pHFATcofEP0XTzMToQkAh7UlG5YBGeFP9VWkBdBa6FF/+83G74RoUQlCiBZBhyIt4SSXYr69lBfOHg== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BY2PR1201MB0919;20:+77Bc397DZQkEpmeEPD/X9Uvep1CxOn2lffWpm43NrEOjsffzn7xIRTnqLFINrQaL4eNZXtfkNhJZYyFBLVKa33HHNaV5H59v3EFX39PGwS1vCX/fF3UBlY7ur+yASyEZnw0+bWNXBXvTr0YjLgI9R0ZwikODE3YPt/Wts7qCWCu+BB8DLtMWIvbh7uVnkftG5pjR/nbnTIhcoWsResbiNdUWt97VE2Xu1LCOI1fMF5dq4Bgb4uaK0NcqLcD45Qe X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2016 20:33:12.6868 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR1201MB0919 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 15.06.2016 um 22:15 schrieb Arnd Bergmann: > In the AMD powerplay driver, a pointer is checked for validity by > comparing against an integer '0', which causes a harmless warning > when building with "make W=1": > > drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/processpptables.c:1502:16: error: ordered comparison of pointer with integer zero [-Werror=extra] > > This changes the code to the more conventional "if (pointer)" check. > > Signed-off-by: Arnd Bergmann Reviewed-by: Christian König . > --- > drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c b/drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c > index 2f1a14fe05b1..b64f42d2c3ae 100644 > --- a/drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c > +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c > @@ -1499,7 +1499,7 @@ int get_number_of_vce_state_table_entries( > const ATOM_PPLIB_VCE_State_Table *vce_table = > get_vce_state_table(hwmgr, table); > > - if (vce_table > 0) > + if (vce_table) > return vce_table->numEntries; > > return 0;