Re: lk 4.7 regression: EDAC, amd64_edac: Drop pci_register_driver() use

Borislav Petkov
2016-06-15T21:50:34Z

On Wed, Jun 15, 2016 at 05:43:42PM -0400, Tony Battersby wrote:
> With that patch applied, modprobe amd64_edac_mod correctly reports "No
> such device" and everything is fine.

Good, thanks!

I'll add your Tested-by to the fix, if you don't mind.

> I also get a new line in dmesg on boot:
>
> amd_nb: Cannot enumerate AMD northbridges

Yeah, comes from init_amd_nbs(). I guess I can remove that pr_notice()
as it is unnecessary noise on distro kernels which enable AMD_NB.

> You might want to consider using -ENODEV instead of -1 for callers such
> as init_amd_nbs() that use the error value.

Yeah, already changed to -ENODEV :-)

Thanks for reporting and testing!

--
Regards/Gruss,
Boris.

ECO tip #101: Trim your mails when you reply.