From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753951AbcFPJok (ORCPT ); Thu, 16 Jun 2016 05:44:40 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:22149 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751711AbcFPJoh (ORCPT ); Thu, 16 Jun 2016 05:44:37 -0400 X-AuditID: cbfec7f5-f792a6d000001302-55-576275013506 Subject: Re: [PATCH 2/5] clk: Combine DT binding doc for max77686 and max77802 To: Laxman Dewangan , javier@osg.samsung.com, mturquette@baylibre.com, robh+dt@kernel.org, linux@armlinux.org.uk References: <1466000018-16784-1-git-send-email-ldewangan@nvidia.com> <1466000018-16784-3-git-send-email-ldewangan@nvidia.com> Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Javier Martinez Canillas From: Krzysztof Kozlowski X-Enigmail-Draft-Status: N1110 Message-id: <57627500.30209@samsung.com> Date: Thu, 16 Jun 2016 11:44:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-version: 1.0 In-reply-to: <1466000018-16784-3-git-send-email-ldewangan@nvidia.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprIIsWRmVeSWpSXmKPExsVy+t/xy7qMpUnhBo/+GljMP3KO1eLa7xls Fm/ermGyeP3C0GLpvtUsFpseX2O1+Nhzj9Xi8q45bBYzzu9jsjg0dS+jxcVTrhate4+wO/B4 XL52kdnj/Y1Wdo+/s1uZPTat6mTz2Lyk3qO3+R2bx5b+u+wefVtWMXp83iQXwBnFZZOSmpNZ llqkb5fAlbFh9m+2gju6FYsXbGJrYJys0sXIySEhYCLRd+gwM4QtJnHh3nq2LkYuDiGBpYwS 8/+sZYdwnjFKzG56BlYlLOAncfvOaTBbRKCDUeLMYUMQW0igXuJ961GwBmaBa4wSjftXghWx CRhLbF6+hA1ihZxEb/ckFhCbV0BD4tO9dWBxFgFViX8TZoDZogIRErO2/2CCqBGU+DH5Hlg9 p4CrxIXVIDUcQAv0JO5f1AIJMwvIS2xe85Z5AqPgLCQdsxCqZiGpWsDIvIpRNLU0uaA4KT3X SK84Mbe4NC9dLzk/dxMjJKK+7mBceszqEKMAB6MSD6/A+sRwIdbEsuLK3EOMEhzMSiK83cVJ 4UK8KYmVValF+fFFpTmpxYcYpTlYlMR5Z+56HyIkkJ5YkpqdmlqQWgSTZeLglGpgPLHObkrn 09+7NpXFvOSfv+0zb31TQ0X7E7OvB1cdXiDiHhzh7S/Vc63ilcRamRBxZSPB0uW/S79bpt8/ tzp3OtuH1AUxF04E+vBMzVpx3nEzK6tjctyWauP3GTOWej1ODJp2XHTVweJ5XxfX7KytSUvx K/if1ho27+n8sIyCkDkHE4s3vAryUmIpzkg01GIuKk4EAPPJwySkAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/15/2016 04:13 PM, Laxman Dewangan wrote: > The clock driver for Maxim PMICs max77686 and max77802 are > combined into single file to extend the support for same clock > IP for different PMICs. > > Remove the separate DT binding document file for maxim,max77802 and > move all information to maxim,max77686 DT binding document. > > Signed-off-by: Laxman Dewangan > CC: Krzysztof Kozlowski > CC: Javier Martinez Canillas > --- > .../devicetree/bindings/clock/maxim,max77686.txt | 78 ++++++++++++++++------ > .../devicetree/bindings/clock/maxim,max77802.txt | 44 ------------ > 2 files changed, 58 insertions(+), 64 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/clock/maxim,max77802.txt > > diff --git a/Documentation/devicetree/bindings/clock/maxim,max77686.txt b/Documentation/devicetree/bindings/clock/maxim,max77686.txt > index 9c40739..354e5ab 100644 > --- a/Documentation/devicetree/bindings/clock/maxim,max77686.txt > +++ b/Documentation/devicetree/bindings/clock/maxim,max77686.txt > @@ -1,11 +1,15 @@ > -Binding for Maxim MAX77686 32k clock generator block > +Binding for Maxim MAX77686/MAX77802 32k clock generator block > > -This is a part of device tree bindings of MAX77686 multi-function device. > -More information can be found in bindings/mfd/max77686.txt file. > +This is a part of device tree bindings of MAX77686/MAX77802 multi-function > +device. More information can be found in bindings/mfd/max77686.txt file for > +MAX77686 and bindings/mfd/max77802.txt for MAX77802. > > The MAX77686 contains three 32.768khz clock outputs that can be controlled > (gated/ungated) over I2C. > > +The MAX77802 contains two 32.768khz clock outputs that can be controlled > +(gated/ungated) over I2C. > + > Following properties should be presend in main device node of the MFD chip. > > Required properties: > @@ -21,26 +25,60 @@ to specify the clock which they consume. Following indices are allowed: > - 1: 32khz_cp clock, > - 2: 32khz_pmic clock. > > +For MAX77802, 32khz_pmic is not valid. It is easier to find for which device which ID is allowed, so maybe: - 1: 32khz_cp clock (max77686, max77802), - 2: 32khz_pmic clock. (max77686) > + > Clocks are defined as preprocessor macros in dt-bindings/clock/maxim,max77686.h > -header and can be used in device tree sources. > +header for MAX77686 and dt-bindings/clock/maxim,max77802.h for MAX77802 and can > +be used in device tree sources. > + > +Example: > + > +1. With MAX77686: > + > +#include > +::: I am not sure what the ":::" means here... Best regards, Krzysztof > + > + Node of the MFD chip > + max77686: max77686@09 { > + compatible = "maxim,max77686"; > + interrupt-parent = <&wakeup_eint>; > + interrupts = <26 0>; > + reg = <0x09>; > + #clock-cells = <1>; > + > + /* ... */ > + }; > + > + Clock consumer node > + > + foo@0 { > + compatible = "bar,foo"; > + /* ... */ > + clock-names = "my-clock"; > + clocks = <&max77686 MAX77686_CLK_PMIC>; > + }; > + > +2. With MAX77802: > > -Example: Node of the MFD chip > +#include > +::: > > - max77686: max77686@09 { > - compatible = "maxim,max77686"; > - interrupt-parent = <&wakeup_eint>; > - interrupts = <26 0>; > - reg = <0x09>; > - #clock-cells = <1>; > + Node of the MFD chip > + max77802: max77802@09 { > + compatible = "maxim,max77802"; > + interrupt-parent = <&wakeup_eint>; > + interrupts = <26 0>; > + reg = <0x09>; > + #clock-cells = <1>; > > - /* ... */ > - }; > + /* ... */ > + }; > > -Example: Clock consumer node > + Clock consumer node > > - foo@0 { > - compatible = "bar,foo"; > - /* ... */ > - clock-names = "my-clock"; > - clocks = <&max77686 MAX77686_CLK_PMIC>; > - }; > + foo@0 { > + compatible = "bar,foo"; > + /* ... */ > + clock-names = "my-clock"; > + clocks = <&max77802 MAX77802_CLK_32K_AP>; > + }; > diff --git a/Documentation/devicetree/bindings/clock/maxim,max77802.txt b/Documentation/devicetree/bindings/clock/maxim,max77802.txt > deleted file mode 100644 > index c6dc783..0000000 > --- a/Documentation/devicetree/bindings/clock/maxim,max77802.txt > +++ /dev/null > @@ -1,44 +0,0 @@ > -Binding for Maxim MAX77802 32k clock generator block > - > -This is a part of device tree bindings of MAX77802 multi-function device. > -More information can be found in bindings/mfd/max77802.txt file. > - > -The MAX77802 contains two 32.768khz clock outputs that can be controlled > -(gated/ungated) over I2C. > - > -Following properties should be present in main device node of the MFD chip. > - > -Required properties: > -- #clock-cells: From common clock binding; shall be set to 1. > - > -Optional properties: > -- clock-output-names: From common clock binding. > - > -Each clock is assigned an identifier and client nodes can use this identifier > -to specify the clock which they consume. Following indices are allowed: > - - 0: 32khz_ap clock, > - - 1: 32khz_cp clock. > - > -Clocks are defined as preprocessor macros in dt-bindings/clock/maxim,max77802.h > -header and can be used in device tree sources. > - > -Example: Node of the MFD chip > - > - max77802: max77802@09 { > - compatible = "maxim,max77802"; > - interrupt-parent = <&wakeup_eint>; > - interrupts = <26 0>; > - reg = <0x09>; > - #clock-cells = <1>; > - > - /* ... */ > - }; > - > -Example: Clock consumer node > - > - foo@0 { > - compatible = "bar,foo"; > - /* ... */ > - clock-names = "my-clock"; > - clocks = <&max77802 MAX77802_CLK_32K_AP>; > - }; >