From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754208AbcFPJtW (ORCPT ); Thu, 16 Jun 2016 05:49:22 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:51622 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752453AbcFPJtM (ORCPT ); Thu, 16 Jun 2016 05:49:12 -0400 X-AuditID: cbfec7f4-f796c6d000001486-4d-5762761591b1 Subject: Re: [PATCH 3/5] clk: max77686: Add DT binding details for PMIC MAX77620 To: Laxman Dewangan , javier@osg.samsung.com, mturquette@baylibre.com, robh+dt@kernel.org, linux@armlinux.org.uk References: <1466000018-16784-1-git-send-email-ldewangan@nvidia.com> <1466000018-16784-4-git-send-email-ldewangan@nvidia.com> Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Javier Martinez Canillas From: Krzysztof Kozlowski Message-id: <57627613.2000409@samsung.com> Date: Thu, 16 Jun 2016 11:49:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-version: 1.0 In-reply-to: <1466000018-16784-4-git-send-email-ldewangan@nvidia.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmplkeLIzCtJLcpLzFFi42I5/e/4ZV3RsqRwg6kbWC3mHznHanHt9ww2 izdv1zBZvH5haLF032oWi02Pr7FafOy5x2pxedccNosZ5/cxWRyaupfR4uIpV4vWvUfYHXg8 Ll+7yOzx/kYru8ff2a3MHptWdbJ5bF5S79Hb/I7NY0v/XXaPvi2rGD0+b5IL4IzisklJzcks Sy3St0vgyuiYsoK9YKNUxZr2TWwNjHNEuxg5OSQETCRa1i9ng7DFJC7cWw9kc3EICSxllDj4 +R0ThPOMUWLB/03MIFXCAgESqx+eBbNFBDoYJc4cNgSxhQTqJb48uM4M0sAscI1RonH/SrAi NgFjic3Ll4Ct4BXQknjz7SULiM0ioCrRt2IpWI2oQITErO0/mCBqBCV+TL4HVsMp4Crxcesl oF4OoKF6EvcvaoGEmQXkJTavecs8gVFgFpKOWQhVs5BULWBkXsUomlqaXFCclJ5rqFecmFtc mpeul5yfu4kREjlfdjAuPmZ1iFGAg1GJh1dgfWK4EGtiWXFl7iFGCQ5mJRHe7uKkcCHelMTK qtSi/Pii0pzU4kOM0hwsSuK8c3e9DxESSE8sSc1OTS1ILYLJMnFwSjUwJrFrX5b3bSu/uo59 253ZkVlu9iH1Sdm2mqfcu3a/KCr68Haz7B7jPRJXvhawtW1gfj/j09+6kA+bzt07W7Jw3xSr P39Xv3DYzOmVWij1d+Z2s1feM9b/fVnz6QTzLO5snwOvljS9Mduht2x2Usj9aZymAYzloqJZ ak9ed8uZM87vLFbcvCH0lRJLcUaioRZzUXEiANhgmrSYAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/15/2016 04:13 PM, Laxman Dewangan wrote: > Maxim has used the same clock IP on multiple PMICs like > MAX77686, MAX77802, MAX77620. Only differences are the > number of clocks from these PMICs. > > Add clock binding details and example for the max77620 in > maxim,max77686. > > Signed-off-by: Laxman Dewangan > CC: Krzysztof Kozlowski > CC: Javier Martinez Canillas > --- > .../devicetree/bindings/clock/maxim,max77686.txt | 38 +++++++++++++++++++--- > include/dt-bindings/mfd/max77620.h | 4 +++ > 2 files changed, 38 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/clock/maxim,max77686.txt b/Documentation/devicetree/bindings/clock/maxim,max77686.txt > index 354e5ab..24deb19 100644 > --- a/Documentation/devicetree/bindings/clock/maxim,max77686.txt > +++ b/Documentation/devicetree/bindings/clock/maxim,max77686.txt > @@ -1,8 +1,11 @@ > -Binding for Maxim MAX77686/MAX77802 32k clock generator block > +Binding for Maxim MAX77686/MAX77802/MAX77620 32k clock generator block > > -This is a part of device tree bindings of MAX77686/MAX77802 multi-function > -device. More information can be found in bindings/mfd/max77686.txt file for > -MAX77686 and bindings/mfd/max77802.txt for MAX77802. > +This is a part of device tree bindings of MAX77686/MAX77802/MAX77620 > +multi-function device. More information can be found in MFD DT binding > +doc as follows: > + bindings/mfd/max77686.txt for MAX77686 and > + bindings/mfd/max77802.txt for MAX77802 and > + bindings/mfd/max77620.txt for MAX77620. > > The MAX77686 contains three 32.768khz clock outputs that can be controlled > (gated/ungated) over I2C. > @@ -10,6 +13,9 @@ The MAX77686 contains three 32.768khz clock outputs that can be controlled > The MAX77802 contains two 32.768khz clock outputs that can be controlled > (gated/ungated) over I2C. > > +The MAX77686 contains one 32.768khz clock outputs that can be controlled > +(gated/ungated) over I2C. > + > Following properties should be presend in main device node of the MFD chip. Please update the information about allowed IDs. > > Required properties: > @@ -82,3 +88,27 @@ Example: > clock-names = "my-clock"; > clocks = <&max77802 MAX77802_CLK_32K_AP>; > }; > + > + > +3. With MAX77620: > + > +#include > +::: Same as before: ':::' > + > + Node of the MFD chip > + max77620: max77620@3c { > + compatible = "maxim,max77620"; > + reg = <0x3c>; > + ::: > + #clock-cells = <1>; > + ::: > + }; > + > + Clock consumer node > + > + foo@0 { > + compatible = "bar,foo"; > + /* ... */ > + clock-names = "my-clock"; > + clocks = <&max77620 MAX77620_CLK_32K_OUT0>; > + }; > diff --git a/include/dt-bindings/mfd/max77620.h b/include/dt-bindings/mfd/max77620.h > index b911a07..e1bd08c 100644 > --- a/include/dt-bindings/mfd/max77620.h > +++ b/include/dt-bindings/mfd/max77620.h > @@ -36,4 +36,8 @@ > #define MAX77620_FPS_SRC_NONE 3 > #define MAX77620_FPS_SRC_DEF 4 > > +/* MAX77686 clocks */ copy&paste error. > +#define MAX77620_CLKS_NUM 1 > +#define MAX77620_CLK_32K_OUT0 0 First clk ID, then NUM. Best regards, Krzysztof > + > #endif >