From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754043AbcFPKLc (ORCPT <rfc822;w@1wt.eu>);
	Thu, 16 Jun 2016 06:11:32 -0400
Received: from mailout1.w1.samsung.com ([210.118.77.11]:56665 "EHLO
	mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751323AbcFPKLa (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 16 Jun 2016 06:11:30 -0400
X-AuditID: cbfec7f5-f792a6d000001302-96-57627b4e8abb
Subject: Re: [PATCH 4/5] clk: max77686: Add support for MAX77620 clocks
To: Laxman Dewangan <ldewangan@nvidia.com>, javier@osg.samsung.com,
        mturquette@baylibre.com, robh+dt@kernel.org, linux@armlinux.org.uk
References: <1466000018-16784-1-git-send-email-ldewangan@nvidia.com>
 <1466000018-16784-5-git-send-email-ldewangan@nvidia.com>
 <57627757.50101@samsung.com> <576276E5.5040500@nvidia.com>
Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org,
        Javier Martinez Canillas <javier@dowhile0.org>
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Message-id: <57627B4C.7060609@samsung.com>
Date: Thu, 16 Jun 2016 12:11:24 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.8.0
MIME-version: 1.0
In-reply-to: <576276E5.5040500@nvidia.com>
Content-type: text/plain; charset=windows-1252
Content-transfer-encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmphkeLIzCtJLcpLzFFi42I5/e/4VV2/6qRwg+u7RC3mHznHanHt9ww2
	izdv1zBZvH5haLF032oWi02Pr7FafOy5x2pxedccNosZ5/cxWRyaupfR4uIpV4vWvUfYHXg8
	Ll+7yOzx/kYru8ff2a3MHptWdbJ5bF5S79Hb/I7NY0v/XXaPvi2rGD0+b5IL4IzisklJzcks
	Sy3St0vgyth86D9rwWWOiidH1rI0MJ5k62Lk4JAQMJFof2vYxcgJZIpJXLi3ng3EFhJYyihx
	cbJiFyMXkP2MUeLXgUWMIAlhAXeJrR0PmEFsEYEORokzhw0hivYwSux9c4ANxGEWuMYo0bh/
	JVgVm4CxxOblS8DG8gpoSbzZ/ZoFxGYRUJXY+uMyWFxUIEJi1vYfTBA1ghI/Jt8Dq+EEqj8x
	azYTyKXMAnoS9y9qgYSZBeQlNq95yzyBUWAWko5ZCFWzkFQtYGRexSiaWppcUJyUnmukV5yY
	W1yal66XnJ+7iRESN193MC49ZnWIUYCDUYmHV2B9YrgQa2JZcWXuIUYJDmYlEV6riqRwId6U
	xMqq1KL8+KLSnNTiQ4zSHCxK4rwzd70PERJITyxJzU5NLUgtgskycXBKNTAyeJwNW6xhLG6m
	oRl3/ayyXX7Oxp/xxyf+7179xKr669ey80yvCvL6Zrj1anhX39lUdcF7wtxTkT9WrI54dv3b
	3eoHunVzRP4arFf0qehWS5Pj2PbMyY3LZPZ3K8lNUTytHYdYXnQcPOr+zN3KMfzadUPBXu7p
	9+UsP5lLZf9ZIJ1qXdmesF2JpTgj0VCLuag4EQBmP5JdlwIAAA==
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 06/16/2016 11:52 AM, Laxman Dewangan wrote:
> Hi Krzysztof/Javier,
> Thanks for review of the series.
> 
> I will post the V2 after taking care of all comment.
> 
> One query about the comment.
> 
> Thanks,
> Laxman
> 
> On Thursday 16 June 2016 03:24 PM, Krzysztof Kozlowski wrote:
>> On 06/15/2016 04:13 PM, Laxman Dewangan wrote:
>>>   enum chip_name {
>>>       CHIP_MAX77686,
>>>       CHIP_MAX77802,
>>> +    CHIP_MAX77620,
>> Now it is more obvious why it is here. However I don't like the
>> duplication of device IDs, under different names and different values:
>> 1. include/linux/mfd/max77686-private.h
>> 2. include/linux/mfd/max77620.h
>> 3. here
>>
>> I was thinking about way of combining it... but these headers are
>> different. Unless there will be one header for all three devices.
>>
>> Anyway, please add the max77686 prefix to the enum.
> 
> so will it be:
> 
> enum max77686_chip_name {
>     CHIP_MAX77686,
>     CHIP_MAX77802,
>     CHIP_MAX77620,
> };
> 
> 
> Will it be fine here?

Yes, looks fine to me.

Best regards,
Krzysztof