From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754437AbcFPNVa (ORCPT ); Thu, 16 Jun 2016 09:21:30 -0400 Received: from hqemgate16.nvidia.com ([216.228.121.65]:13281 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753866AbcFPNV2 (ORCPT ); Thu, 16 Jun 2016 09:21:28 -0400 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Thu, 16 Jun 2016 06:17:52 -0700 Message-ID: <5762A4BE.3010408@nvidia.com> Date: Thu, 16 Jun 2016 18:38:14 +0530 From: Laxman Dewangan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Javier Martinez Canillas , Krzysztof Kozlowski , , , CC: , , , , , Javier Martinez Canillas Subject: Re: [PATCH 5/5] ARM: config: Get rid of config COMMON_CLK_MAX77802 References: <1466000018-16784-1-git-send-email-ldewangan@nvidia.com> <1466000018-16784-6-git-send-email-ldewangan@nvidia.com> <3fa0a098-3b28-9baa-8950-a944cce86b65@osg.samsung.com> <57629AB9.2090506@samsung.com> In-Reply-To: X-Originating-IP: [10.19.65.30] X-ClientProxiedBy: DRHKMAIL101.nvidia.com (10.25.59.15) To bgmail102.nvidia.com (10.25.59.11) Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 16 June 2016 06:36 PM, Javier Martinez Canillas wrote: > Hello Krzysztof, > > On 06/16/2016 08:25 AM, Krzysztof Kozlowski wrote: >> On 06/15/2016 05:39 PM, Javier Martinez Canillas wrote: >>> Hello Laxman, >>> >>> On 06/15/2016 10:13 AM, Laxman Dewangan wrote: >>>> The clock driver used by Maxim PMIC MAX77802 is clk-max77686 >>>> which can be enabled with config CONFIG_COMMON_CLK_MAX77686. >>>> >>>> Hence the config CONFIG_COMMON_CLK_MAX77802 is not required. >>>> >>>> Signed-off-by: Laxman Dewangan >>>> CC: Krzysztof Kozlowski >>>> CC: Javier Martinez Canillas >>>> --- >>>> arch/arm/configs/exynos_defconfig | 1 - >>>> arch/arm/configs/multi_v7_defconfig | 1 - >>> Please split these two changes in separate patches, there are just >>> cleanups needed after 1/5 and they can be picked separately. >> Not entirely separately. If we do not want to loose max77802 clocks on >> defconfigs, then it should go with the same tree or after driver get >> merged. I prefer the latter, similar case to 1898994229f8 ("ARM: >> multi_v7_defconfig: Switch max77693 to module"). >> > Agreed. Your latter example is what I tried to say (that can be picked > as cleanups separately once 1/5 hits mainline). I just didn't express > clearly. > > OK, I will drop this from series when will send V2. The changes can be done later on once clock changes get merged.