From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755190AbcFPO0c (ORCPT <rfc822;w@1wt.eu>);
	Thu, 16 Jun 2016 10:26:32 -0400
Received: from mail-wm0-f54.google.com ([74.125.82.54]:37482 "EHLO
	mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754602AbcFPO00 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 16 Jun 2016 10:26:26 -0400
Subject: Re: [PATCH v2 0/4] clocksource: rockchip/timer: Support rktimer for
 rk3399
To: Caesar Wang <wxt@rock-chips.com>, Heiko Stuebner <heiko@sntech.de>
References: <1465275273-22076-1-git-send-email-wxt@rock-chips.com>
Cc: dianders@chromium.org, briannorris@google.com, smbarber@google.com,
        linux-rockchip@lists.infradead.org,
        Thomas Gleixner <tglx@linutronix.de>, cf@rock-chips.com,
        huangtao@rock-chips.com, devicetree@vger.kernel.org,
        Xing Zheng <zhengxing@rock-chips.com>,
        Jianqun Xu <jay.xu@rock-chips.com>,
        Masahiro Yamada <yamada.masahiro@socionext.com>,
        Brian Norris <briannorris@chromium.org>, linux-kernel@vger.kernel.org,
        Shawn Lin <shawn.lin@rock-chips.com>, Rob Herring <robh+dt@kernel.org>,
        Will Deacon <will.deacon@arm.com>, Mark Rutland <mark.rutland@arm.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        linux-arm-kernel@lists.infradead.org
From: Daniel Lezcano <daniel.lezcano@linaro.org>
Message-ID: <5762B70E.7090909@linaro.org>
Date: Thu, 16 Jun 2016 16:26:22 +0200
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <1465275273-22076-1-git-send-email-wxt@rock-chips.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 06/07/2016 06:54 AM, Caesar Wang wrote:
> This series patches had been tested on rockchip inside kernel.
> In order to support the rk3399 SoC timer and turn off interrupts and IPIs to
> save power in idle.
> Okay, it still works bootup on rk3288/other SoCs, even though many socs hasn't used
> the broadcast timer.
>
> History version:
> v1:
> https://lkml.org/lkml/2016/5/25/186
>
> Easy to test for my borad.
> localhost / # cat /proc/interrupts
> CPU0       CPU1       CPU2       CPU3       CPU4       CPU5
> 1:          0          0          0          0          0          0     GICv3  29 Edge      arch_timer
> ...
> 5:          0          0          0          0          0          0     GICv3 113 Level     rk_timer
> ..
>
> localhost / # cat /proc/timer_list | grep event_handler
> get "event_handler:  hrtimer_interrupt"
> event_handler:  tick_handle_oneshot_broadcast
> event_handler:  hrtimer_interrupt
>
> That should work for my board.

Hi Caesar,

I applied the patches on my tree. I humbly reworded the changelog, if 
you disagree with the content, let me know.

Please, in the future, take care of the following:

  - patch prefix is 'clocksource/driver/<driver_name>: [A-Z].*'

  - the change log is important, it deserves some love.

Thanks.

   -- Daniel


-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog