* [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)
@ 2016-06-17 1:05 Jim Gill
2016-06-17 1:19 ` Arvind Kumar
` (2 more replies)
0 siblings, 3 replies; 14+ messages in thread
From: Jim Gill @ 2016-06-17 1:05 UTC (permalink / raw)
To: jejb, martin.petersen; +Cc: arvindkumar, pv-drivers, linux-scsi, linux-kernel
From 6a076cc00ec12c6f9cba58ee7e4c3dec49e1e7e5 Mon Sep 17 00:00:00 2001
From: Jim Gill <jgill@vmware.com>
Date: Thu, 16 Jun 2016 14:10:43 -0700
Subject: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)
Signed-off-by: Jim Gill <jgill@vmware.com>
---
drivers/scsi/vmw_pvscsi.c | 2 +-
drivers/scsi/vmw_pvscsi.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/vmw_pvscsi.c b/drivers/scsi/vmw_pvscsi.c
index 6164634..4a0d3cd 100644
--- a/drivers/scsi/vmw_pvscsi.c
+++ b/drivers/scsi/vmw_pvscsi.c
@@ -17,7 +17,7 @@
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
- * Maintained by: Arvind Kumar <arvindkumar@vmware.com>
+ * Maintained by: Jim Gill <jgill@vmware.com>
*
*/
diff --git a/drivers/scsi/vmw_pvscsi.h b/drivers/scsi/vmw_pvscsi.h
index 12712c9..c097d2c 100644
--- a/drivers/scsi/vmw_pvscsi.h
+++ b/drivers/scsi/vmw_pvscsi.h
@@ -17,7 +17,7 @@
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
- * Maintained by: Arvind Kumar <arvindkumar@vmware.com>
+ * Maintained by: Jim Gill <jgill@vmware.com>
*
*/
--
2.5.0
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email) 2016-06-17 1:05 [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email) Jim Gill @ 2016-06-17 1:19 ` Arvind Kumar 2016-06-17 1:48 ` Julian Calaby 2016-06-21 2:01 ` Martin K. Petersen 2 siblings, 0 replies; 14+ messages in thread From: Arvind Kumar @ 2016-06-17 1:19 UTC (permalink / raw) To: Jim Gill, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com Cc: pv-drivers@vmware.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Looks fine to me. Acked-by: Arvind Kumar (arvindkumar@vmware.com) Thanks! Arvind ________________________________________ From: Jim Gill <jgill@vmware.com> Sent: Thursday, June 16, 2016 6:05 PM To: jejb@linux.vnet.ibm.com; martin.petersen@oracle.com Cc: Arvind Kumar; pv-drivers@vmware.com; linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org Subject: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email) From 6a076cc00ec12c6f9cba58ee7e4c3dec49e1e7e5 Mon Sep 17 00:00:00 2001 From: Jim Gill <jgill@vmware.com> Date: Thu, 16 Jun 2016 14:10:43 -0700 Subject: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email) Signed-off-by: Jim Gill <jgill@vmware.com> --- drivers/scsi/vmw_pvscsi.c | 2 +- drivers/scsi/vmw_pvscsi.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/vmw_pvscsi.c b/drivers/scsi/vmw_pvscsi.c index 6164634..4a0d3cd 100644 --- a/drivers/scsi/vmw_pvscsi.c +++ b/drivers/scsi/vmw_pvscsi.c @@ -17,7 +17,7 @@ * along with this program; if not, write to the Free Software * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. * - * Maintained by: Arvind Kumar <arvindkumar@vmware.com> + * Maintained by: Jim Gill <jgill@vmware.com> * */ diff --git a/drivers/scsi/vmw_pvscsi.h b/drivers/scsi/vmw_pvscsi.h index 12712c9..c097d2c 100644 --- a/drivers/scsi/vmw_pvscsi.h +++ b/drivers/scsi/vmw_pvscsi.h @@ -17,7 +17,7 @@ * along with this program; if not, write to the Free Software * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. * - * Maintained by: Arvind Kumar <arvindkumar@vmware.com> + * Maintained by: Jim Gill <jgill@vmware.com> * */ -- 2.5.0 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email) 2016-06-17 1:05 [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email) Jim Gill 2016-06-17 1:19 ` Arvind Kumar @ 2016-06-17 1:48 ` Julian Calaby 2016-06-17 2:03 ` Arvind Kumar 2016-06-21 2:01 ` Martin K. Petersen 2 siblings, 1 reply; 14+ messages in thread From: Julian Calaby @ 2016-06-17 1:48 UTC (permalink / raw) To: Jim Gill Cc: jejb, Martin K. Petersen, arvindkumar, pv-drivers, linux-scsi, linux-kernel@vger.kernel.org Hi Jim, On Fri, Jun 17, 2016 at 11:05 AM, Jim Gill <jgill@vmware.com> wrote: > From 6a076cc00ec12c6f9cba58ee7e4c3dec49e1e7e5 Mon Sep 17 00:00:00 2001 > From: Jim Gill <jgill@vmware.com> > Date: Thu, 16 Jun 2016 14:10:43 -0700 > Subject: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, > email) > > Signed-off-by: Jim Gill <jgill@vmware.com> > --- > drivers/scsi/vmw_pvscsi.c | 2 +- > drivers/scsi/vmw_pvscsi.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/vmw_pvscsi.c b/drivers/scsi/vmw_pvscsi.c > index 6164634..4a0d3cd 100644 > --- a/drivers/scsi/vmw_pvscsi.c > +++ b/drivers/scsi/vmw_pvscsi.c > @@ -17,7 +17,7 @@ > * along with this program; if not, write to the Free Software > * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 > USA. > * > - * Maintained by: Arvind Kumar <arvindkumar@vmware.com> > + * Maintained by: Jim Gill <jgill@vmware.com> Shouldn't you update MAINTAINERs too? And isn't having this information in these files redundant? Thanks, -- Julian Calaby Email: julian.calaby@gmail.com Profile: http://www.google.com/profiles/julian.calaby/ ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email) 2016-06-17 1:48 ` Julian Calaby @ 2016-06-17 2:03 ` Arvind Kumar 2016-06-17 2:18 ` Julian Calaby 0 siblings, 1 reply; 14+ messages in thread From: Arvind Kumar @ 2016-06-17 2:03 UTC (permalink / raw) To: Julian Calaby, Jim Gill Cc: jejb@linux.vnet.ibm.com, Martin K. Petersen, pv-drivers@vmware.com, linux-scsi, linux-kernel@vger.kernel.org Hi Julian, Thanks for spotting that. We will update that too. I don't really see it as redundant rather as a quick reference instead of digging out the MAINTAINERS file and then search for vmw_pvscsi.c file. Specially for those readers who might not even know about the MAINTAINERS file. Thanks! Arvind ________________________________________ From: Julian Calaby <julian.calaby@gmail.com> Sent: Thursday, June 16, 2016 6:48 PM To: Jim Gill Cc: jejb@linux.vnet.ibm.com; Martin K. Petersen; Arvind Kumar; pv-drivers@vmware.com; linux-scsi; linux-kernel@vger.kernel.org Subject: Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email) Hi Jim, On Fri, Jun 17, 2016 at 11:05 AM, Jim Gill <jgill@vmware.com> wrote: > From 6a076cc00ec12c6f9cba58ee7e4c3dec49e1e7e5 Mon Sep 17 00:00:00 2001 > From: Jim Gill <jgill@vmware.com> > Date: Thu, 16 Jun 2016 14:10:43 -0700 > Subject: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, > email) > > Signed-off-by: Jim Gill <jgill@vmware.com> > --- > drivers/scsi/vmw_pvscsi.c | 2 +- > drivers/scsi/vmw_pvscsi.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/vmw_pvscsi.c b/drivers/scsi/vmw_pvscsi.c > index 6164634..4a0d3cd 100644 > --- a/drivers/scsi/vmw_pvscsi.c > +++ b/drivers/scsi/vmw_pvscsi.c > @@ -17,7 +17,7 @@ > * along with this program; if not, write to the Free Software > * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 > USA. > * > - * Maintained by: Arvind Kumar <arvindkumar@vmware.com> > + * Maintained by: Jim Gill <jgill@vmware.com> Shouldn't you update MAINTAINERs too? And isn't having this information in these files redundant? Thanks, -- Julian Calaby Email: julian.calaby@gmail.com Profile: https://urldefense.proofpoint.com/v2/url?u=http-3A__www.google.com_profiles_julian.calaby_&d=CwIBaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=bUMaNc7nC9xbXtaMJrOvIIPNpPH0chY2kdRsskQn6GY&m=JibRIMgSBQLffjc5PofQnpJ0k_gawmvafvIKpsEaMzk&s=CeVpY1FwvY9Qlb0VDeQUXeeL3kuVkcIKTZIC7exS6SM&e= ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email) 2016-06-17 2:03 ` Arvind Kumar @ 2016-06-17 2:18 ` Julian Calaby 2016-06-17 2:33 ` Joe Perches 0 siblings, 1 reply; 14+ messages in thread From: Julian Calaby @ 2016-06-17 2:18 UTC (permalink / raw) To: Arvind Kumar Cc: Jim Gill, jejb@linux.vnet.ibm.com, Martin K. Petersen, pv-drivers@vmware.com, linux-scsi, linux-kernel@vger.kernel.org Hi Arvind, On Fri, Jun 17, 2016 at 12:03 PM, Arvind Kumar <arvindkumar@vmware.com> wrote: > Hi Julian, > > Thanks for spotting that. We will update that too. > > I don't really see it as redundant rather as a quick reference instead of digging out the MAINTAINERS file and then search for vmw_pvscsi.c file. Specially for those readers who might not even know about the MAINTAINERS file. You can use the get_maintainers script in the scripts directory to quickly get information from MAINTAINERS, i.e.: ./scripts/get_maintainers.pl -f drivers/scsi/vmw_pvscsi.c or ./scripts/get_maintainers.pl patchfile.patch Thanks, Julian Calaby > > Thanks! > Arvind > ________________________________________ > From: Julian Calaby <julian.calaby@gmail.com> > Sent: Thursday, June 16, 2016 6:48 PM > To: Jim Gill > Cc: jejb@linux.vnet.ibm.com; Martin K. Petersen; Arvind Kumar; pv-drivers@vmware.com; linux-scsi; linux-kernel@vger.kernel.org > Subject: Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email) > > Hi Jim, > > On Fri, Jun 17, 2016 at 11:05 AM, Jim Gill <jgill@vmware.com> wrote: >> From 6a076cc00ec12c6f9cba58ee7e4c3dec49e1e7e5 Mon Sep 17 00:00:00 2001 >> From: Jim Gill <jgill@vmware.com> >> Date: Thu, 16 Jun 2016 14:10:43 -0700 >> Subject: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, >> email) >> >> Signed-off-by: Jim Gill <jgill@vmware.com> >> --- >> drivers/scsi/vmw_pvscsi.c | 2 +- >> drivers/scsi/vmw_pvscsi.h | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/scsi/vmw_pvscsi.c b/drivers/scsi/vmw_pvscsi.c >> index 6164634..4a0d3cd 100644 >> --- a/drivers/scsi/vmw_pvscsi.c >> +++ b/drivers/scsi/vmw_pvscsi.c >> @@ -17,7 +17,7 @@ >> * along with this program; if not, write to the Free Software >> * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 >> USA. >> * >> - * Maintained by: Arvind Kumar <arvindkumar@vmware.com> >> + * Maintained by: Jim Gill <jgill@vmware.com> > > Shouldn't you update MAINTAINERs too? And isn't having this > information in these files redundant? > > Thanks, > > -- > Julian Calaby > > Email: julian.calaby@gmail.com > Profile: https://urldefense.proofpoint.com/v2/url?u=http-3A__www.google.com_profiles_julian.calaby_&d=CwIBaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=bUMaNc7nC9xbXtaMJrOvIIPNpPH0chY2kdRsskQn6GY&m=JibRIMgSBQLffjc5PofQnpJ0k_gawmvafvIKpsEaMzk&s=CeVpY1FwvY9Qlb0VDeQUXeeL3kuVkcIKTZIC7exS6SM&e= -- Julian Calaby Email: julian.calaby@gmail.com Profile: http://www.google.com/profiles/julian.calaby/ ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email) 2016-06-17 2:18 ` Julian Calaby @ 2016-06-17 2:33 ` Joe Perches 2016-06-17 2:44 ` Julian Calaby 0 siblings, 1 reply; 14+ messages in thread From: Joe Perches @ 2016-06-17 2:33 UTC (permalink / raw) To: Julian Calaby, Arvind Kumar Cc: Jim Gill, jejb@linux.vnet.ibm.com, Martin K. Petersen, pv-drivers@vmware.com, linux-scsi, linux-kernel@vger.kernel.org On Fri, 2016-06-17 at 12:18 +1000, Julian Calaby wrote: > ./scripts/get_maintainers.pl -f drivers/scsi/vmw_pvscsi.c just fyi: the script name is not plural $ ./scripts/get_maintainer.pl -f drivers/scsi/vmw_pvscsi.c Arvind Kumar <arvindkumar@vmware.com> (maintainer:VMware PVSCSI driver) VMware PV-Drivers <pv-drivers@vmware.com> (maintainer:VMware PVSCSI driver) "James E.J. Bottomley" <jejb@linux.vnet.ibm.com> (maintainer:SCSI SUBSYSTEM) "Martin K. Petersen" <martin.petersen@oracle.com> (maintainer:SCSI SUBSYSTEM) linux-scsi@vger.kernel.org (open list:VMware PVSCSI driver) linux-kernel@vger.kernel.org (open list) and another fyi: get_maintainer.pl also has a rarely used "--file-emails" option to scan for what appears to be email addresses in specific files. $ ./scripts/get_maintainer.pl -f --file-emails drivers/scsi/vmw_pvscsi.c Arvind Kumar <arvindkumar@vmware.com> (maintainer:VMware PVSCSI driver,in file) VMware PV-Drivers <pv-drivers@vmware.com> (maintainer:VMware PVSCSI driver) "James E.J. Bottomley" <jejb@linux.vnet.ibm.com> (maintainer:SCSI SUBSYSTEM) "Martin K. Petersen" <martin.petersen@oracle.com> (maintainer:SCSI SUBSYSTEM) linux-scsi@vger.kernel.org (open list:VMware PVSCSI driver) linux-kernel@vger.kernel.org (open list) note the "in file" after Arvind's name ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email) 2016-06-17 2:33 ` Joe Perches @ 2016-06-17 2:44 ` Julian Calaby 2016-06-17 3:04 ` Joe Perches 0 siblings, 1 reply; 14+ messages in thread From: Julian Calaby @ 2016-06-17 2:44 UTC (permalink / raw) To: Joe Perches Cc: Arvind Kumar, Jim Gill, jejb@linux.vnet.ibm.com, Martin K. Petersen, pv-drivers@vmware.com, linux-scsi, linux-kernel@vger.kernel.org Hi Joe, On Fri, Jun 17, 2016 at 12:33 PM, Joe Perches <joe@perches.com> wrote: > On Fri, 2016-06-17 at 12:18 +1000, Julian Calaby wrote: >> ./scripts/get_maintainers.pl -f drivers/scsi/vmw_pvscsi.c > > just fyi: the script name is not plural Thanks, must have typo'd it between running it and typing it into the email. > $ ./scripts/get_maintainer.pl -f drivers/scsi/vmw_pvscsi.c > Arvind Kumar <arvindkumar@vmware.com> (maintainer:VMware PVSCSI driver) > VMware PV-Drivers <pv-drivers@vmware.com> (maintainer:VMware PVSCSI driver) > "James E.J. Bottomley" <jejb@linux.vnet.ibm.com> (maintainer:SCSI SUBSYSTEM) > "Martin K. Petersen" <martin.petersen@oracle.com> (maintainer:SCSI SUBSYSTEM) > linux-scsi@vger.kernel.org (open list:VMware PVSCSI driver) > linux-kernel@vger.kernel.org (open list) > > and another fyi: > > get_maintainer.pl also has a rarely used "--file-emails" option to > scan for what appears to be email addresses in specific files. > > $ ./scripts/get_maintainer.pl -f --file-emails drivers/scsi/vmw_pvscsi.c > Arvind Kumar <arvindkumar@vmware.com> (maintainer:VMware PVSCSI driver,in file) > VMware PV-Drivers <pv-drivers@vmware.com> (maintainer:VMware PVSCSI driver) > "James E.J. Bottomley" <jejb@linux.vnet.ibm.com> (maintainer:SCSI SUBSYSTEM) > "Martin K. Petersen" <martin.petersen@oracle.com> (maintainer:SCSI SUBSYSTEM) > linux-scsi@vger.kernel.org (open list:VMware PVSCSI driver) > linux-kernel@vger.kernel.org (open list) > > note the "in file" after Arvind's name Didn't know this, however my point stands: the maintainer line in the file is redundant if we find maintainers through MAINTAINERS or the get_maintainer.pl script. Thanks, -- Julian Calaby Email: julian.calaby@gmail.com Profile: http://www.google.com/profiles/julian.calaby/ ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email) 2016-06-17 2:44 ` Julian Calaby @ 2016-06-17 3:04 ` Joe Perches 2016-06-17 3:11 ` Julian Calaby 0 siblings, 1 reply; 14+ messages in thread From: Joe Perches @ 2016-06-17 3:04 UTC (permalink / raw) To: Julian Calaby Cc: Arvind Kumar, Jim Gill, jejb@linux.vnet.ibm.com, Martin K. Petersen, pv-drivers@vmware.com, linux-scsi, linux-kernel@vger.kernel.org On Fri, 2016-06-17 at 12:44 +1000, Julian Calaby wrote: > Hi Joe, rehi Julian. > On Fri, Jun 17, 2016 at 12:33 PM, Joe Perches <joe@perches.com> wrote: [] > > get_maintainer.pl also has a rarely used "--file-emails" option to > > scan for what appears to be email addresses in specific files. > > > > $ ./scripts/get_maintainer.pl -f --file-emails drivers/scsi/vmw_pvscsi.c > > Arvind Kumar <arvindkumar@vmware.com> (maintainer:VMware PVSCSI driver,in file) > > VMware PV-Drivers <pv-drivers@vmware.com> (maintainer:VMware PVSCSI driver) > > "James E.J. Bottomley" <jejb@linux.vnet.ibm.com> (maintainer:SCSI SUBSYSTEM) > > "Martin K. Petersen" <martin.petersen@oracle.com> (maintainer:SCSI SUBSYSTEM) > > linux-scsi@vger.kernel.org (open list:VMware PVSCSI driver) > > linux-kernel@vger.kernel.org (open list) > > > > note the "in file" after Arvind's name > Didn't know this, however my point stands: the maintainer line in the > file is redundant if we find maintainers through MAINTAINERS or the > get_maintainer.pl script. Yes, I'm not suggesting anything else. Jim's name should appear in the MAINTAINERS file somewhere. The question to me is whether or not Jim Gill is taking over the maintainership of the entire VMware PVSCSI driver or just a few files of it. ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email) 2016-06-17 3:04 ` Joe Perches @ 2016-06-17 3:11 ` Julian Calaby 2016-06-17 7:55 ` [Pv-drivers] " Thomas Hellstrom 2016-06-17 17:44 ` Jim Gill 0 siblings, 2 replies; 14+ messages in thread From: Julian Calaby @ 2016-06-17 3:11 UTC (permalink / raw) To: Joe Perches Cc: Arvind Kumar, Jim Gill, jejb@linux.vnet.ibm.com, Martin K. Petersen, pv-drivers@vmware.com, linux-scsi, linux-kernel@vger.kernel.org Hi Joe, On Fri, Jun 17, 2016 at 1:04 PM, Joe Perches <joe@perches.com> wrote: > On Fri, 2016-06-17 at 12:44 +1000, Julian Calaby wrote: >> Hi Joe, > > rehi Julian. (I always put a salutation on my emails and always finish them with "Thanks," =) ) >> On Fri, Jun 17, 2016 at 12:33 PM, Joe Perches <joe@perches.com> wrote: > [] >> > get_maintainer.pl also has a rarely used "--file-emails" option to >> > scan for what appears to be email addresses in specific files. >> > >> > $ ./scripts/get_maintainer.pl -f --file-emails drivers/scsi/vmw_pvscsi.c >> > Arvind Kumar <arvindkumar@vmware.com> (maintainer:VMware PVSCSI driver,in file) >> > VMware PV-Drivers <pv-drivers@vmware.com> (maintainer:VMware PVSCSI driver) >> > "James E.J. Bottomley" <jejb@linux.vnet.ibm.com> (maintainer:SCSI SUBSYSTEM) >> > "Martin K. Petersen" <martin.petersen@oracle.com> (maintainer:SCSI SUBSYSTEM) >> > linux-scsi@vger.kernel.org (open list:VMware PVSCSI driver) >> > linux-kernel@vger.kernel.org (open list) >> > >> > note the "in file" after Arvind's name >> Didn't know this, however my point stands: the maintainer line in the >> file is redundant if we find maintainers through MAINTAINERS or the >> get_maintainer.pl script. > > Yes, I'm not suggesting anything else. Jim's name > should appear in the MAINTAINERS file somewhere. > > The question to me is whether or not Jim Gill is > taking over the maintainership of the entire > VMware PVSCSI driver or just a few files of it. As I see it, he's taking over maintainership of all of it: it's only files are drivers/scsi/vmw_pvscsi.[ch] AFAIK. Thanks, -- Julian Calaby Email: julian.calaby@gmail.com Profile: http://www.google.com/profiles/julian.calaby/ ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Pv-drivers] [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email) 2016-06-17 3:11 ` Julian Calaby @ 2016-06-17 7:55 ` Thomas Hellstrom 2016-06-17 17:44 ` Jim Gill 1 sibling, 0 replies; 14+ messages in thread From: Thomas Hellstrom @ 2016-06-17 7:55 UTC (permalink / raw) To: Julian Calaby, Joe Perches Cc: jejb@linux.vnet.ibm.com, Martin K. Petersen, linux-scsi, pv-drivers@vmware.com, linux-kernel@vger.kernel.org, Jim Gill Hi! IMO we shouldn't have maintainer info mentioned in the source files, since the information is redundant and moreover if we change maintainer a patch touching multiple files would just look odd, and we'd leave a lot of stale info in older kernels. Having the linux git *master* MAINTAINERS file as the authoritative information source for this makes most sense. If there are different maintainers of different parts of a single module we should be able to sort that out internally. Thanks, Thomas On 06/17/2016 05:11 AM, Julian Calaby wrote: > Hi Joe, > > On Fri, Jun 17, 2016 at 1:04 PM, Joe Perches <joe@perches.com> wrote: >> On Fri, 2016-06-17 at 12:44 +1000, Julian Calaby wrote: >>> Hi Joe, >> rehi Julian. > (I always put a salutation on my emails and always finish them with > "Thanks," =) ) > >>> On Fri, Jun 17, 2016 at 12:33 PM, Joe Perches <joe@perches.com> wrote: >> [] >>>> get_maintainer.pl also has a rarely used "--file-emails" option to >>>> scan for what appears to be email addresses in specific files. >>>> >>>> $ ./scripts/get_maintainer.pl -f --file-emails drivers/scsi/vmw_pvscsi.c >>>> Arvind Kumar <arvindkumar@vmware.com> (maintainer:VMware PVSCSI driver,in file) >>>> VMware PV-Drivers <pv-drivers@vmware.com> (maintainer:VMware PVSCSI driver) >>>> "James E.J. Bottomley" <jejb@linux.vnet.ibm.com> (maintainer:SCSI SUBSYSTEM) >>>> "Martin K. Petersen" <martin.petersen@oracle.com> (maintainer:SCSI SUBSYSTEM) >>>> linux-scsi@vger.kernel.org (open list:VMware PVSCSI driver) >>>> linux-kernel@vger.kernel.org (open list) >>>> >>>> note the "in file" after Arvind's name >>> Didn't know this, however my point stands: the maintainer line in the >>> file is redundant if we find maintainers through MAINTAINERS or the >>> get_maintainer.pl script. >> Yes, I'm not suggesting anything else. Jim's name >> should appear in the MAINTAINERS file somewhere. >> >> The question to me is whether or not Jim Gill is >> taking over the maintainership of the entire >> VMware PVSCSI driver or just a few files of it. > As I see it, he's taking over maintainership of all of it: it's only > files are drivers/scsi/vmw_pvscsi.[ch] AFAIK. > > Thanks, > ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email) 2016-06-17 3:11 ` Julian Calaby 2016-06-17 7:55 ` [Pv-drivers] " Thomas Hellstrom @ 2016-06-17 17:44 ` Jim Gill 2016-06-17 18:06 ` Joe Perches 1 sibling, 1 reply; 14+ messages in thread From: Jim Gill @ 2016-06-17 17:44 UTC (permalink / raw) To: Julian Calaby, Joe Perches Cc: Arvind Kumar, jejb@linux.vnet.ibm.com, Martin K. Petersen, pv-drivers@vmware.com, linux-scsi, linux-kernel@vger.kernel.org On 6/16/16, 8:11 PM, "Julian Calaby" <julian.calaby@gmail.com> wrote: >[] > >>>On Fri, Jun 17, 2016 at 12:33 PM, Joe Perches <joe@perches.com> wrote: >> [] >>The question to me is whether or not Jim Gill is >> taking over the maintainership of the entire >> VMware PVSCSI driver or just a few files of it. > >As I see it, he's taking over maintainership of all of it: it's only >files are drivers/scsi/vmw_pvscsi.[ch] AFAIK. This is correct, I am taking over maintainership of the entire vmw_pvscsi driver. ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email) 2016-06-17 17:44 ` Jim Gill @ 2016-06-17 18:06 ` Joe Perches 2016-06-17 18:16 ` Jim Gill 0 siblings, 1 reply; 14+ messages in thread From: Joe Perches @ 2016-06-17 18:06 UTC (permalink / raw) To: Jim Gill, Julian Calaby Cc: Arvind Kumar, jejb@linux.vnet.ibm.com, Martin K. Petersen, pv-drivers@vmware.com, linux-scsi, linux-kernel@vger.kernel.org On Fri, 2016-06-17 at 17:44 +0000, Jim Gill wrote: > On 6/16/16, 8:11 PM, "Julian Calaby" <julian.calaby@gmail.com> wrote: > > > > > > > [] > > > > > > > > > > > > > On Fri, Jun 17, 2016 at 12:33 PM, Joe Perches <joe@perches.com> wrote: > > > [] > > > The question to me is whether or not Jim Gill is > > > taking over the maintainership of the entire > > > VMware PVSCSI driver or just a few files of it. > > As I see it, he's taking over maintainership of all of it: it's only > > files are drivers/scsi/vmw_pvscsi.[ch] AFAIK. > This is correct, I am taking over maintainership of the entire vmw_pvscsi driver. Perhaps a patch like this: >From e727c6549e3be466ec3c79e919502cb0b9909b03 Mon Sep 17 00:00:00 2001 Message-Id: <e727c6549e3be466ec3c79e919502cb0b9909b03.1466186573.git.joe@perches.com> From: Joe Perches <joe@perches.com> Date: Fri, 17 Jun 2016 10:56:49 -0700 Subject: [PATCH] vmw_pvscsi: Move into separate directory, Jim Gill is MAINTAINER Separate directories for drivers are generally better. Miscellanea: o Update the MAINTAINER entry o Remove maintainer and FSF addresses from driver files --- MAINTAINERS | 5 ++--- drivers/scsi/Kconfig | 8 +------- drivers/scsi/Makefile | 2 +- drivers/scsi/vmware/Kconfig | 7 +++++++ drivers/scsi/vmware/Makefile | 1 + drivers/scsi/{ => vmware}/vmw_pvscsi.c | 7 ------- drivers/scsi/{ => vmware}/vmw_pvscsi.h | 7 ------- 7 files changed, 12 insertions(+), 25 deletions(-) create mode 100644 drivers/scsi/vmware/Kconfig create mode 100644 drivers/scsi/vmware/Makefile rename drivers/scsi/{ => vmware}/vmw_pvscsi.c (99%) rename drivers/scsi/{ => vmware}/vmw_pvscsi.h (98%) diff --git a/MAINTAINERS b/MAINTAINERS index d174e34..2763582 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -12421,12 +12421,11 @@ S: Maintained F: drivers/net/vmxnet3/ VMware PVSCSI driver -M: Arvind Kumar <arvindkumar@vmware.com> +M: Jim Gill <jgill@vmware.com> M: VMware PV-Drivers <pv-drivers@vmware.com> L: linux-scsi@vger.kernel.org S: Maintained -F: drivers/scsi/vmw_pvscsi.c -F: drivers/scsi/vmw_pvscsi.h +F: drivers/scsi/vmware/ VOLTAGE AND CURRENT REGULATOR FRAMEWORK M: Liam Girdwood <lgirdwood@gmail.com> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig index 1918f54..339c230 100644 --- a/drivers/scsi/Kconfig +++ b/drivers/scsi/Kconfig @@ -576,13 +576,7 @@ config SCSI_FLASHPOINT substantial, so users of MultiMaster Host Adapters may not wish to include it. -config VMWARE_PVSCSI - tristate "VMware PVSCSI driver support" - depends on PCI && SCSI && X86 - help - This driver supports VMware's para virtualized SCSI HBA. - To compile this driver as a module, choose M here: the - module will be called vmw_pvscsi. +source "drivers/scsi/vmware/Kconfig" config XEN_SCSI_FRONTEND tristate "XEN SCSI frontend driver" diff --git a/drivers/scsi/Makefile b/drivers/scsi/Makefile index 862ab4e..6cfefaa 100644 --- a/drivers/scsi/Makefile +++ b/drivers/scsi/Makefile @@ -141,7 +141,7 @@ obj-$(CONFIG_BE2ISCSI) += libiscsi.o be2iscsi/ obj-$(CONFIG_SCSI_ESAS2R) += esas2r/ obj-$(CONFIG_SCSI_PMCRAID) += pmcraid.o obj-$(CONFIG_SCSI_VIRTIO) += virtio_scsi.o -obj-$(CONFIG_VMWARE_PVSCSI) += vmw_pvscsi.o +obj-$(CONFIG_VMWARE_PVSCSI) += vmware/ obj-$(CONFIG_XEN_SCSI_FRONTEND) += xen-scsifront.o obj-$(CONFIG_HYPERV_STORAGE) += hv_storvsc.o obj-$(CONFIG_SCSI_WD719X) += wd719x.o diff --git a/drivers/scsi/vmware/Kconfig b/drivers/scsi/vmware/Kconfig new file mode 100644 index 0000000..3c0c53b --- /dev/null +++ b/drivers/scsi/vmware/Kconfig @@ -0,0 +1,7 @@ +config VMWARE_PVSCSI + tristate "VMware PVSCSI driver support" + depends on PCI && SCSI && X86 + help + This driver supports VMware's para virtualized SCSI HBA. + To compile this driver as a module, choose M here: the + module will be called vmw_pvscsi. diff --git a/drivers/scsi/vmware/Makefile b/drivers/scsi/vmware/Makefile new file mode 100644 index 0000000..ae8d278 --- /dev/null +++ b/drivers/scsi/vmware/Makefile @@ -0,0 +1 @@ +obj-$(CONFIG_VMWARE_PVSCSI) += vmw_pvscsi.o diff --git a/drivers/scsi/vmw_pvscsi.c b/drivers/scsi/vmware/vmw_pvscsi.c similarity index 99% rename from drivers/scsi/vmw_pvscsi.c rename to drivers/scsi/vmware/vmw_pvscsi.c index 6164634..eb1229e 100644 --- a/drivers/scsi/vmw_pvscsi.c +++ b/drivers/scsi/vmware/vmw_pvscsi.c @@ -12,13 +12,6 @@ * MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE, GOOD TITLE or * NON INFRINGEMENT. See the GNU General Public License for more * details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. - * - * Maintained by: Arvind Kumar <arvindkumar@vmware.com> - * */ #include <linux/kernel.h> diff --git a/drivers/scsi/vmw_pvscsi.h b/drivers/scsi/vmware/vmw_pvscsi.h similarity index 98% rename from drivers/scsi/vmw_pvscsi.h rename to drivers/scsi/vmware/vmw_pvscsi.h index 12712c9..5f675b9 100644 --- a/drivers/scsi/vmw_pvscsi.h +++ b/drivers/scsi/vmware/vmw_pvscsi.h @@ -12,13 +12,6 @@ * MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE, GOOD TITLE or * NON INFRINGEMENT. See the GNU General Public License for more * details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. - * - * Maintained by: Arvind Kumar <arvindkumar@vmware.com> - * */ #ifndef _VMW_PVSCSI_H_ -- 2.8.0.rc4.16.g56331f8 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email) 2016-06-17 18:06 ` Joe Perches @ 2016-06-17 18:16 ` Jim Gill 0 siblings, 0 replies; 14+ messages in thread From: Jim Gill @ 2016-06-17 18:16 UTC (permalink / raw) To: Joe Perches, Julian Calaby Cc: Arvind Kumar, jejb@linux.vnet.ibm.com, Martin K. Petersen, pv-drivers@vmware.com, linux-scsi, linux-kernel@vger.kernel.org I don’t yet know enough to comment on the relocation of vmw_pvscsi into a new vmware folder. I was considering offering a new patch that removed the “maintained by” from the two source files and updated MAINTAINERS, but I’m happy to defer to people with more experience. I’m fine either way. On 6/17/16, 11:06 AM, "Joe Perches" <joe@perches.com> wrote: > >Perhaps a patch like this: > >From e727c6549e3be466ec3c79e919502cb0b9909b03 Mon Sep 17 00:00:00 2001 >Message-Id: <e727c6549e3be466ec3c79e919502cb0b9909b03.1466186573.git.joe@perches.com> >From: Joe Perches <joe@perches.com> >Date: Fri, 17 Jun 2016 10:56:49 -0700 >Subject: [PATCH] vmw_pvscsi: Move into separate directory, Jim Gill is MAINTAINER > >Separate directories for drivers are generally better. > >Miscellanea: > >o Update the MAINTAINER entry >o Remove maintainer and FSF addresses from driver files >--- > MAINTAINERS | 5 ++--- > drivers/scsi/Kconfig | 8 +------- > drivers/scsi/Makefile | 2 +- > drivers/scsi/vmware/Kconfig | 7 +++++++ > drivers/scsi/vmware/Makefile | 1 + > drivers/scsi/{ => vmware}/vmw_pvscsi.c | 7 ------- > drivers/scsi/{ => vmware}/vmw_pvscsi.h | 7 ------- > 7 files changed, 12 insertions(+), 25 deletions(-) > create mode 100644 drivers/scsi/vmware/Kconfig > create mode 100644 drivers/scsi/vmware/Makefile > rename drivers/scsi/{ => vmware}/vmw_pvscsi.c (99%) > rename drivers/scsi/{ => vmware}/vmw_pvscsi.h (98%) > >diff --git a/MAINTAINERS b/MAINTAINERS >index d174e34..2763582 100644 >--- a/MAINTAINERS >+++ b/MAINTAINERS >@@ -12421,12 +12421,11 @@ S: Maintained > F: drivers/net/vmxnet3/ > > VMware PVSCSI driver >-M: Arvind Kumar <arvindkumar@vmware.com> >+M: Jim Gill <jgill@vmware.com> > M: VMware PV-Drivers <pv-drivers@vmware.com> > L: linux-scsi@vger.kernel.org > S: Maintained >-F: drivers/scsi/vmw_pvscsi.c >-F: drivers/scsi/vmw_pvscsi.h >+F: drivers/scsi/vmware/ > > VOLTAGE AND CURRENT REGULATOR FRAMEWORK > M: Liam Girdwood <lgirdwood@gmail.com> >diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig >index 1918f54..339c230 100644 >--- a/drivers/scsi/Kconfig >+++ b/drivers/scsi/Kconfig >@@ -576,13 +576,7 @@ config SCSI_FLASHPOINT > substantial, so users of MultiMaster Host Adapters may not > wish to include it. > >-config VMWARE_PVSCSI >- tristate "VMware PVSCSI driver support" >- depends on PCI && SCSI && X86 >- help >- This driver supports VMware's para virtualized SCSI HBA. >- To compile this driver as a module, choose M here: the >- module will be called vmw_pvscsi. >+source "drivers/scsi/vmware/Kconfig" > > config XEN_SCSI_FRONTEND > tristate "XEN SCSI frontend driver" >diff --git a/drivers/scsi/Makefile b/drivers/scsi/Makefile >index 862ab4e..6cfefaa 100644 >--- a/drivers/scsi/Makefile >+++ b/drivers/scsi/Makefile >@@ -141,7 +141,7 @@ obj-$(CONFIG_BE2ISCSI) += libiscsi.o be2iscsi/ > obj-$(CONFIG_SCSI_ESAS2R) += esas2r/ > obj-$(CONFIG_SCSI_PMCRAID) += pmcraid.o > obj-$(CONFIG_SCSI_VIRTIO) += virtio_scsi.o >-obj-$(CONFIG_VMWARE_PVSCSI) += vmw_pvscsi.o >+obj-$(CONFIG_VMWARE_PVSCSI) += vmware/ > obj-$(CONFIG_XEN_SCSI_FRONTEND) += xen-scsifront.o > obj-$(CONFIG_HYPERV_STORAGE) += hv_storvsc.o > obj-$(CONFIG_SCSI_WD719X) += wd719x.o >diff --git a/drivers/scsi/vmware/Kconfig b/drivers/scsi/vmware/Kconfig >new file mode 100644 >index 0000000..3c0c53b >--- /dev/null >+++ b/drivers/scsi/vmware/Kconfig >@@ -0,0 +1,7 @@ >+config VMWARE_PVSCSI >+ tristate "VMware PVSCSI driver support" >+ depends on PCI && SCSI && X86 >+ help >+ This driver supports VMware's para virtualized SCSI HBA. >+ To compile this driver as a module, choose M here: the >+ module will be called vmw_pvscsi. >diff --git a/drivers/scsi/vmware/Makefile b/drivers/scsi/vmware/Makefile >new file mode 100644 >index 0000000..ae8d278 >--- /dev/null >+++ b/drivers/scsi/vmware/Makefile >@@ -0,0 +1 @@ >+obj-$(CONFIG_VMWARE_PVSCSI) += vmw_pvscsi.o >diff --git a/drivers/scsi/vmw_pvscsi.c b/drivers/scsi/vmware/vmw_pvscsi.c >similarity index 99% >rename from drivers/scsi/vmw_pvscsi.c >rename to drivers/scsi/vmware/vmw_pvscsi.c >index 6164634..eb1229e 100644 >--- a/drivers/scsi/vmw_pvscsi.c >+++ b/drivers/scsi/vmware/vmw_pvscsi.c >@@ -12,13 +12,6 @@ > * MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE, GOOD TITLE or > * NON INFRINGEMENT. See the GNU General Public License for more > * details. >- * >- * You should have received a copy of the GNU General Public License >- * along with this program; if not, write to the Free Software >- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. >- * >- * Maintained by: Arvind Kumar <arvindkumar@vmware.com> >- * > */ > > #include <linux/kernel.h> >diff --git a/drivers/scsi/vmw_pvscsi.h b/drivers/scsi/vmware/vmw_pvscsi.h >similarity index 98% >rename from drivers/scsi/vmw_pvscsi.h >rename to drivers/scsi/vmware/vmw_pvscsi.h >index 12712c9..5f675b9 100644 >--- a/drivers/scsi/vmw_pvscsi.h >+++ b/drivers/scsi/vmware/vmw_pvscsi.h >@@ -12,13 +12,6 @@ > * MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE, GOOD TITLE or > * NON INFRINGEMENT. See the GNU General Public License for more > * details. >- * >- * You should have received a copy of the GNU General Public License >- * along with this program; if not, write to the Free Software >- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. >- * >- * Maintained by: Arvind Kumar <arvindkumar@vmware.com> >- * > */ > > #ifndef _VMW_PVSCSI_H_ >-- >2.8.0.rc4.16.g56331f8 > ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email) 2016-06-17 1:05 [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email) Jim Gill 2016-06-17 1:19 ` Arvind Kumar 2016-06-17 1:48 ` Julian Calaby @ 2016-06-21 2:01 ` Martin K. Petersen 2 siblings, 0 replies; 14+ messages in thread From: Martin K. Petersen @ 2016-06-21 2:01 UTC (permalink / raw) To: Jim Gill Cc: jejb, martin.petersen, arvindkumar, pv-drivers, linux-scsi, linux-kernel >>>>> "Jim" == Jim Gill <jgill@vmware.com> writes: Updated MAINTAINERS accordingly and applied to 4.8/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering ^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2016-06-21 2:02 UTC | newest] Thread overview: 14+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-06-17 1:05 [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email) Jim Gill 2016-06-17 1:19 ` Arvind Kumar 2016-06-17 1:48 ` Julian Calaby 2016-06-17 2:03 ` Arvind Kumar 2016-06-17 2:18 ` Julian Calaby 2016-06-17 2:33 ` Joe Perches 2016-06-17 2:44 ` Julian Calaby 2016-06-17 3:04 ` Joe Perches 2016-06-17 3:11 ` Julian Calaby 2016-06-17 7:55 ` [Pv-drivers] " Thomas Hellstrom 2016-06-17 17:44 ` Jim Gill 2016-06-17 18:06 ` Joe Perches 2016-06-17 18:16 ` Jim Gill 2016-06-21 2:01 ` Martin K. Petersen
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox