From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755108AbcFQGCF (ORCPT ); Fri, 17 Jun 2016 02:02:05 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:27497 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753830AbcFQGCC (ORCPT ); Fri, 17 Jun 2016 02:02:02 -0400 X-AuditID: cbfec7f4-f796c6d000001486-56-5763925701fa Subject: Re: [PATCH V2 1/4] clk: max77686: Combine Maxim max77686 and max77802 driver To: Laxman Dewangan , javier@osg.samsung.com, mturquette@baylibre.com, robh+dt@kernel.org, linux@armlinux.org.uk References: <1466083407-28793-1-git-send-email-ldewangan@nvidia.com> <1466083407-28793-2-git-send-email-ldewangan@nvidia.com> Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Javier Martinez Canillas From: Krzysztof Kozlowski Message-id: <57639255.3010403@samsung.com> Date: Fri, 17 Jun 2016 08:01:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-version: 1.0 In-reply-to: <1466083407-28793-2-git-send-email-ldewangan@nvidia.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpikeLIzCtJLcpLzFFi42I5/e/4Vd3wScnhBpcnsFnMP3KO1eLa7xls Fm/ermGyeP3C0GLpvtUsFpseX2O1+Nhzj9Xi8q45bBYzzu9jsjg0dS+jxcVTrhate4+wO/B4 XL52kdnj/Y1Wdo+/s1uZPTat6mTz2Lyk3qO3+R2bx5b+u+wefVtWMXp83iQXwBnFZZOSmpNZ llqkb5fAlXH5/RzWgk/8FR0b3RsY//N0MXJySAiYSDyY1sYEYYtJXLi3nq2LkYtDSGApo0Tj kQWsEM4zRomHN/sZQaqEBcIlZk3sYAexRQQ6GCXOHDYEsYUE6iW2Te0Ha2AWuAbUvX8lM0iC TcBYYvPyJWwgNq+AlsT7HSuABnFwsAioSvzqUAEJiwpESMza/oMJokRQ4sfkeywgJZwCrhK7 JnuDmMwCehL3L2qBVDALyEtsXvOWeQKjwCwkDbMQqmYhqVrAyLyKUTS1NLmgOCk911CvODG3 uDQvXS85P3cTIyRmvuxgXHzM6hCjAAejEg/vCtHkcCHWxLLiytxDjBIczEoivHt6gUK8KYmV ValF+fFFpTmpxYcYpTlYlMR55+56HyIkkJ5YkpqdmlqQWgSTZeLglGpgzLlvdKXt79TZzrc4 gh9xpP823+oxe9L77NsJfkFGTuETfb58c1BVmXe5Q1F702KrbW55tbUSb9fc83fx/hqWuPbP 1r6aW/1MkyJCKrvrCtS/87OE9r/6mrhr717LoJ3r/LvmJuq9friBU+qtyfFq/vWLrTjm6Hdp NpsUfDm3ltHf5OHrpdoTlFiKMxINtZiLihMBnfRAVpUCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/16/2016 03:23 PM, Laxman Dewangan wrote: > The clock IP used on the Maxim PMICs max77686 and max77802 are > same. The configuration of clock register is also same except > the number of clocks. > > Part of common code utilisation, there is 3 files for these chips > clock driver, one for common and two files for driver registration. > > Combine both drivers into single file and move common code into > same common file reduces the 2 files and make max77686 and max77802 > clock driver in single fine. This driver does not depends on the > parent driver structure. The regmap handle is acquired through > regmap APIs for the register access. > > This combination of driver helps on adding clock driver for different > Maxim PMICs which has similar clock IP like MAX77620 and MAX20024. > > Signed-off-by: Laxman Dewangan > CC: Krzysztof Kozlowski > CC: Javier Martinez Canillas > Reviewed-by: Javier Martinez Canillas > Tested-by: Javier Martinez Canillas > Tested-by: Krzysztof Kozlowski > > --- > Changes from V1: > - Collected RB and TB from Javier. > - Change the max_gen to max77686. > - Rename structure and avoid duplication for reg and mask. > - Taken care of comment from Krzysztof on coding. > --- > drivers/clk/Kconfig | 15 +-- > drivers/clk/Makefile | 2 - > drivers/clk/clk-max-gen.c | 194 ----------------------------------- > drivers/clk/clk-max-gen.h | 32 ------ > drivers/clk/clk-max77686.c | 244 ++++++++++++++++++++++++++++++++++++++++++--- > drivers/clk/clk-max77802.c | 96 ------------------ > 6 files changed, 234 insertions(+), 349 deletions(-) > delete mode 100644 drivers/clk/clk-max-gen.c > delete mode 100644 drivers/clk/clk-max-gen.h > delete mode 100644 drivers/clk/clk-max77802.c Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof