From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755195AbcFQGfu (ORCPT ); Fri, 17 Jun 2016 02:35:50 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:28826 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752665AbcFQGfs (ORCPT ); Fri, 17 Jun 2016 02:35:48 -0400 X-AuditID: cbfec7f4-f796c6d000001486-38-57639a41f7f1 Subject: Re: [PATCH v3 5/7] max8903: removes non zero validity checks on gpios. To: Chris Lapa , dwmw2@infradead.org, dbaryshkov@gmail.com, sre@kernel.org, mark.rutland@arm.com, robh+dt@kernel.org References: <1464849897-21527-3-git-send-email-chris@lapa.com.au> <1466139626-51434-1-git-send-email-chris@lapa.com.au> <1466139626-51434-6-git-send-email-chris@lapa.com.au> Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org From: Krzysztof Kozlowski Message-id: <57639A3F.90607@samsung.com> Date: Fri, 17 Jun 2016 08:35:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-version: 1.0 In-reply-to: <1466139626-51434-6-git-send-email-chris@lapa.com.au> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrALMWRmVeSWpSXmKPExsVy+t/xK7qOs5LDDeYeErB4eMbMYtKT98wW 84+cY7WYuHIys8XrF4YWl3fNYbP43HuE0WLp9YtMFq17j7BbnN5d4sDlsWbeGkaPnbPusnts XqHlsWlVJ5vHsrmbGT36tqxi9Pi8SS6APYrLJiU1J7MstUjfLoErY8K/GawFR1krPt+awdbA eJKli5GTQ0LARKJz9i1mCFtM4sK99WxdjFwcQgJLGSW2H//BAuE8Y5R4/eoeG0iVsIC/xOW3 r1hBEiICnYwS319uZ4So2sgosW/7IUaQKmaBCInOB4fYQWw2AWOJzcuXgHXzCmhILNoFUsPB wSKgKrH9VjpIWBSofNb2H0wQJYISPybfAzuPU8BJ4sqTx2DlzAJ6EvcvakFMl5fYvOYt8wRG gVlIOmYhVM1CUrWAkXkVo2hqaXJBcVJ6rqFecWJucWleul5yfu4mRkg8fNnBuPiY1SFGAQ5G JR7eFaLJ4UKsiWXFlbmHGCU4mJVEeDWnA4V4UxIrq1KL8uOLSnNSiw8xSnOwKInzzt31PkRI ID2xJDU7NbUgtQgmy8TBKdXAqBmtrRTtveuo++tHq1V+b3pmxVPyoMN/+baco+bSGz1mHGPI 5rnP+dr9yP/Xbw5ZVN8zucr84mpf5s/Cx6n39ZxkX/jb2cWERx8+u8X+w7SM5AyhrSKFVzUK 2c+sSK8/eWHJmczklhP3SmuPcR2Yff4k+86vXclzfy/o6zii7iR4YvJE5ymPJZRYijMSDbWY i4oTAe72QOGDAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/17/2016 07:00 AM, Chris Lapa wrote: > From: Chris Lapa > > Prior to this commit a zero gpio was treated as invalid. Whereas > gpio_is_valid() will treat a zero gpio as valid. > > This commit removes the confusion and explicity uses gpio_is_valid() s/explicity/explicitly/ > throughout. Which in turn results in several of the error messages becoming > redundant and thus removed. > > Signed-off-by: Chris Lapa > --- > drivers/power/max8903_charger.c | 125 ++++++++++++++++++---------------------- > 1 file changed, 55 insertions(+), 70 deletions(-) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof