From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755377AbcFQGpW (ORCPT ); Fri, 17 Jun 2016 02:45:22 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:29226 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751114AbcFQGpU (ORCPT ); Fri, 17 Jun 2016 02:45:20 -0400 X-AuditID: cbfec7f5-f792a6d000001302-20-57639c7dae8e Message-id: <57639C7D.2030706@samsung.com> Date: Fri, 17 Jun 2016 08:45:17 +0200 From: Jacek Anaszewski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8 MIME-version: 1.0 To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Mauro Carvalho Chehab , Andrzej Pietrasiewicz , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Subject: Re: [PATCH 4/6] [media] s5p-jpeg: only fill driver's name in capabilities driver field References: <1466113235-25909-1-git-send-email-javier@osg.samsung.com> <1466113235-25909-5-git-send-email-javier@osg.samsung.com> In-reply-to: <1466113235-25909-5-git-send-email-javier@osg.samsung.com> Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrILMWRmVeSWpSXmKPExsVy+t/xK7q1c5LDDZ6dtLGY9bKdxeLN2zVM FpseX2O1uLxrDptFz4atrBarn1U4sHlsXlLvsaX/LrtH35ZVjB6fN8kFsERx2aSk5mSWpRbp 2yVwZUxZOJGpoJm/4sQsuQbG39xdjJwcEgImEm1v7rND2GISF+6tZ+ti5OIQEljKKLH3dAMj hPOMUeL9mWOsIFW8AloSX38fButgEVCVaFzdAGazCRhK/HzxmgnEFhWIkPhzeh9UvaDEj8n3 WEBsEQFTiV9rX7CCDGUWOMkosfnnAjaQhLBAosTppadYILY1M0rsXrwDrJtTwF1i1eezYFOZ BawlVk7axghhy0tsXvOWeQKjwCwkS2YhKZuFpGwBI/MqRtHU0uSC4qT0XCO94sTc4tK8dL3k /NxNjJCA/rqDcekxq0OMAhyMSjy8K0STw4VYE8uKK3MPMUpwMCuJ8D6YDRTiTUmsrEotyo8v Ks1JLT7EKM3BoiTOO3PX+xAhgfTEktTs1NSC1CKYLBMHp1QD40bz3VJNzt1bJbmf1L91NEtp croaap5nNbMsjWN/g6PYHvWy+RXWW3s3W4vNPT1Do2934erMc2JzAnQjrzHGamrM+/fdlfeJ 7ZYXryuPhRxYZhR1j+niYUa2t3qLpAtd7V+ftDi0bYfOn20cx1Qn789LuWj0acrsG28V5LRu bBDuDfC//F2/WYmlOCPRUIu5qDgRAKZiEC5kAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Javier, On 06/16/2016 11:40 PM, Javier Martinez Canillas wrote: > The driver fills in both the struct v4l2_capability driver and card fields > the same values, that is the driver's name plus the information if the dev > is a decoder or an encoder. > > But the driver field has a fixed length of 16 bytes so the filled data is > truncated: > > Driver Info (not using libv4l2): > Driver name : s5p-jpeg decode > Card type : s5p-jpeg decoder > Bus info : platform:11f50000.jpeg > Driver version: 4.7.0 > > Also, this field should only contain the driver's name so use just that. > The information if the device is a decoder or an encoder is in the card > type field anyways. > > Signed-off-by: Javier Martinez Canillas > --- > > drivers/media/platform/s5p-jpeg/jpeg-core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/s5p-jpeg/jpeg-core.c b/drivers/media/platform/s5p-jpeg/jpeg-core.c > index e3ff3d4bd72e..f9fb52a53e79 100644 > --- a/drivers/media/platform/s5p-jpeg/jpeg-core.c > +++ b/drivers/media/platform/s5p-jpeg/jpeg-core.c > @@ -1246,12 +1246,12 @@ static int s5p_jpeg_querycap(struct file *file, void *priv, > struct s5p_jpeg_ctx *ctx = fh_to_ctx(priv); > > if (ctx->mode == S5P_JPEG_ENCODE) { > - strlcpy(cap->driver, S5P_JPEG_M2M_NAME " encoder", > + strlcpy(cap->driver, S5P_JPEG_M2M_NAME, > sizeof(cap->driver)); > strlcpy(cap->card, S5P_JPEG_M2M_NAME " encoder", > sizeof(cap->card)); > } else { > - strlcpy(cap->driver, S5P_JPEG_M2M_NAME " decoder", > + strlcpy(cap->driver, S5P_JPEG_M2M_NAME, > sizeof(cap->driver)); > strlcpy(cap->card, S5P_JPEG_M2M_NAME " decoder", > sizeof(cap->card)); > Acked-by: Jacek Anaszewski -- Best regards, Jacek Anaszewski