From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754260AbcFQG6d (ORCPT ); Fri, 17 Jun 2016 02:58:33 -0400 Received: from mail-wm0-f42.google.com ([74.125.82.42]:36233 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750774AbcFQG6c (ORCPT ); Fri, 17 Jun 2016 02:58:32 -0400 Subject: Re: [PATCH V2 62/63] clocksource/drivers/oxnas-rps: Convert init function to return error To: Daniel Lezcano , tglx@linutronix.de References: <1466112442-31105-1-git-send-email-daniel.lezcano@linaro.org> <1466112442-31105-63-git-send-email-daniel.lezcano@linaro.org> Cc: linux-kernel@vger.kernel.org, "moderated list:ARM/OXNAS platfor..." From: Neil Armstrong Organization: Baylibre Message-ID: <57639F94.9010400@baylibre.com> Date: Fri, 17 Jun 2016 08:58:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1466112442-31105-63-git-send-email-daniel.lezcano@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/16/2016 11:27 PM, Daniel Lezcano wrote: > The init functions do not return any error. They behave as the following: > > - panic, thus leading to a kernel crash while another timer may work and > make the system boot up correctly > > or > > - print an error and let the caller unaware if the state of the system > > Change that by converting the init functions to return an error conforming > to the CLOCKSOURCE_OF_RET prototype. > > Proper error handling (rollback, errno value) will be changed later case > by case, thus this change just return back an error or success in the init > function. > > Signed-off-by: Daniel Lezcano > --- > drivers/clocksource/timer-oxnas-rps.c | 33 ++++++++++++++++++++------------- > 1 file changed, 20 insertions(+), 13 deletions(-) Acked-by: Neil Armstrong Thanks, Neil