From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754843AbcFQHFG (ORCPT ); Fri, 17 Jun 2016 03:05:06 -0400 Received: from lb2-smtp-cloud3.xs4all.net ([194.109.24.26]:57602 "EHLO lb2-smtp-cloud3.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754541AbcFQHFA (ORCPT ); Fri, 17 Jun 2016 03:05:00 -0400 Subject: Re: [RFC] [PATCH 0/3] media: an attempt to refresh omap1_camera driver To: Janusz Krzysztofik , Mauro Carvalho Chehab , Greg Kroah-Hartman References: <1466097694-8660-1-git-send-email-jmkrzyszt@gmail.com> Cc: Guennadi Liakhovetski , Amitoj Kaur Chawla , Arnd Bergmann , Tony Lindgren , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, linux-omap@vger.kernel.org From: Hans Verkuil Message-ID: <5763A114.2080309@xs4all.nl> Date: Fri, 17 Jun 2016 09:04:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.7.2 MIME-Version: 1.0 In-Reply-To: <1466097694-8660-1-git-send-email-jmkrzyszt@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Janusz, On 06/16/2016 07:21 PM, Janusz Krzysztofik wrote: > As requested by media subsystem maintainers, here is an attempt to > convert the omap1_camera driver to the vb2 framework. Also, conversion > to the dmaengine framework, long awaited by ARM/OMAP maintainers, is > done. > > Next, I'm going to approach removal of soc-camera dependency. Please > let me know how much time I have for that, i.e., when the soc-camera > framework is going to be depreciated. Well, it is already deprecated (i.e. new drivers cannot use it), but it won't be removed any time soon. There are still drivers depending on it, and some aren't easy to rewrite. I have to say that it is totally unexpected to see that this omap1 driver is still used. In fact, we've already merged a patch that removed it for the upcoming 4.8 kernel. Based on this new development I'll revert that for the omap1 driver. Out of curiosity: is supporting the Amstrad Delta something you do as a hobby or are there other reasons? A final note: once you've managed to drop the soc-camera dependency you should run the v4l2-compliance test over the video node (https://git.linuxtv.org/v4l-utils.git/). If that passes without failures, then this driver is in good shape and can be moved out of staging again. Regards, Hans > > Thanks, > Janusz > > > Janusz Krzysztofik (3): > staging: media: omap1: drop videobuf-dma-sg mode > staging: media: omap1: convert to videobuf2 > staging: media: omap1: use dmaengine > > drivers/staging/media/omap1/Kconfig | 5 +- > drivers/staging/media/omap1/omap1_camera.c | 948 +++++------------------ > include/linux/platform_data/media/omap1_camera.h | 9 - > 3 files changed, 217 insertions(+), 745 deletions(-) >