From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755023AbcFQHVb (ORCPT ); Fri, 17 Jun 2016 03:21:31 -0400 Received: from hqemgate16.nvidia.com ([216.228.121.65]:10386 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752815AbcFQHVa (ORCPT ); Fri, 17 Jun 2016 03:21:30 -0400 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Fri, 17 Jun 2016 00:18:42 -0700 Subject: Re: [PATCH V2 33/63] clocksource/drivers/time-armada-370-xp: Convert init function to return error To: Daniel Lezcano , References: <1466112442-31105-1-git-send-email-daniel.lezcano@linaro.org> <1466112442-31105-34-git-send-email-daniel.lezcano@linaro.org> CC: , Stephen Warren , Thierry Reding , Alexandre Courbot , "open list:TEGRA ARCHITECTUR..." From: Jon Hunter Message-ID: <5763A4F4.30102@nvidia.com> Date: Fri, 17 Jun 2016 08:21:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1466112442-31105-34-git-send-email-daniel.lezcano@linaro.org> X-Originating-IP: [10.21.132.108] X-ClientProxiedBy: UKMAIL102.nvidia.com (10.26.138.15) To UKMAIL102.nvidia.com (10.26.138.15) Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/06/16 22:26, Daniel Lezcano wrote: > The init functions do not return any error. They behave as the following: > > - panic, thus leading to a kernel crash while another timer may work and > make the system boot up correctly > > or > > - print an error and let the caller unaware if the state of the system > > Change that by converting the init functions to return an error conforming > to the CLOCKSOURCE_OF_RET prototype. > > Proper error handling (rollback, errno value) will be changed later case > by case, thus this change just return back an error or success in the init > function. > > Signed-off-by: Daniel Lezcano > --- > drivers/clocksource/tegra20_timer.c | 28 ++++++++++++++++------------ > 1 file changed, 16 insertions(+), 12 deletions(-) The $subject does not appear to match with the driver you are modifying here. Cheers Jon -- nvpublic