From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754804AbcFQHbK (ORCPT <rfc822;w@1wt.eu>);
	Fri, 17 Jun 2016 03:31:10 -0400
Received: from eusmtp01.atmel.com ([212.144.249.243]:5750 "EHLO
	eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751711AbcFQHbI (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 17 Jun 2016 03:31:08 -0400
Subject: Re: [PATCH 1/6] memory: atmel-sdramc: make it explicitly non-modular
To: Paul Gortmaker <paul.gortmaker@windriver.com>,
        <linux-kernel@vger.kernel.org>
References: <20160617003748.12188-1-paul.gortmaker@windriver.com>
 <20160617003748.12188-2-paul.gortmaker@windriver.com>
CC: Alexandre Belloni <alexandre.belloni@free-electrons.com>
From: Nicolas Ferre <nicolas.ferre@atmel.com>
Organization: atmel
Message-ID: <5763A733.2020607@atmel.com>
Date: Fri, 17 Jun 2016 09:30:59 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.8.0
MIME-Version: 1.0
In-Reply-To: <20160617003748.12188-2-paul.gortmaker@windriver.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 8bit
X-Originating-IP: [10.161.30.18]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Le 17/06/2016 02:37, Paul Gortmaker a écrit :
> The Kconfig for this option is currently:
> 
> config ATMEL_SDRAMC
>         bool "Atmel (Multi-port DDR-)SDRAM Controller"
> 
> ...meaning that it currently is not being built as a module by anyone.
> Lets remove the couple traces of modularity, so that when reading the
> driver there is no doubt it is builtin-only.
> 
> Since module_init translates to device_initcall in the non-modular
> case, the init ordering remains unchanged with this commit.  An
> alternate init level might be worth considering at a later date.
> 
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
> 
> We also delete the MODULE_LICENSE tag etc. since all that information
> was (or is now) contained at the top of the file in the comments.
> 
> Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> Cc: Nicolas Ferre <nicolas.ferre@atmel.com>

Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> ---
>  drivers/memory/atmel-sdramc.c | 11 ++++-------
>  1 file changed, 4 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/memory/atmel-sdramc.c b/drivers/memory/atmel-sdramc.c
> index a3ebc8a87479..53a341f3b305 100644
> --- a/drivers/memory/atmel-sdramc.c
> +++ b/drivers/memory/atmel-sdramc.c
> @@ -1,6 +1,8 @@
>  /*
>   * Atmel (Multi-port DDR-)SDRAM Controller driver
>   *
> + * Author: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> + *
>   * Copyright (C) 2014 Atmel
>   *
>   * This program is free software: you can redistribute it and/or modify
> @@ -20,7 +22,7 @@
>  #include <linux/clk.h>
>  #include <linux/err.h>
>  #include <linux/kernel.h>
> -#include <linux/module.h>
> +#include <linux/init.h>
>  #include <linux/of_platform.h>
>  #include <linux/platform_device.h>
>  
> @@ -48,7 +50,6 @@ static const struct of_device_id atmel_ramc_of_match[] = {
>  	{ .compatible = "atmel,sama5d3-ddramc", .data = &sama5d3_caps, },
>  	{},
>  };
> -MODULE_DEVICE_TABLE(of, atmel_ramc_of_match);
>  
>  static int atmel_ramc_probe(struct platform_device *pdev)
>  {
> @@ -90,8 +91,4 @@ static int __init atmel_ramc_init(void)
>  {
>  	return platform_driver_register(&atmel_ramc_driver);
>  }
> -module_init(atmel_ramc_init);
> -
> -MODULE_LICENSE("GPL v2");
> -MODULE_AUTHOR("Alexandre Belloni <alexandre.belloni@free-electrons.com>");
> -MODULE_DESCRIPTION("Atmel (Multi-port DDR-)SDRAM Controller");
> +device_initcall(atmel_ramc_init);
> 


-- 
Nicolas Ferre