From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933651AbcFQLHG (ORCPT ); Fri, 17 Jun 2016 07:07:06 -0400 Received: from mail.ispras.ru ([83.149.199.45]:35328 "EHLO mail.ispras.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753469AbcFQLHD (ORCPT ); Fri, 17 Jun 2016 07:07:03 -0400 Subject: Re: [BUG] act_ife: sleeping functions called in atomic context To: Cong Wang , Jamal Hadi Salim References: <1466110219-4825-1-git-send-email-khoroshilov@ispras.ru> <57634687.3050107@mojatatu.com> Cc: "David S. Miller" , Linux Kernel Network Developers , LKML , ldv-project@linuxtesting.org From: Alexey Khoroshilov Message-ID: <5763D970.3030504@ispras.ru> Date: Fri, 17 Jun 2016 14:05:20 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17.06.2016 08:38, Cong Wang wrote: > On Thu, Jun 16, 2016 at 7:14 PM, Cong Wang wrote: >> >> I think we can just remove that tcf_lock, I am testing a patch now. > > Please try the attached patch, I will do more tests tomorrow. > > Thanks! > Looks good with two notes: 1. add_metainfo() still contains ret = ops->alloc(mi, metaval); that allocates memory with GFP_KERNEL. So, I would add gfpflag argument to alloc() operation. 2. It makes sense to mention ife_mod_lock in the comment before add_metainfo(), because ife_mod_lock is the reason to use GFP_ATOMIC there. -- Alexey