From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754329AbcFQNQJ (ORCPT <rfc822;w@1wt.eu>);
	Fri, 17 Jun 2016 09:16:09 -0400
Received: from arroyo.ext.ti.com ([198.47.19.12]:43637 "EHLO arroyo.ext.ti.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751309AbcFQNQG (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 17 Jun 2016 09:16:06 -0400
Subject: Re: [PATCH] phy: rockchip-dp: fix return value check in
 rockchip_dp_phy_probe()
To: =?UTF-8?Q?Heiko_St=c3=bcbner?= <heiko@sntech.de>, <weiyj_lk@163.com>
References: <1465860707-26005-1-git-send-email-weiyj_lk@163.com>
 <4354296.6MbJoqdM2Z@diego>
CC: Wei Yongjun <yongjun_wei@trendmicro.com.cn>,
        <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>,
        <linux-rockchip@lists.infradead.org>
From: Kishon Vijay Abraham I <kishon@ti.com>
Message-ID: <5763F7E6.9090702@ti.com>
Date: Fri, 17 Jun 2016 18:45:18 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.2
MIME-Version: 1.0
In-Reply-To: <4354296.6MbJoqdM2Z@diego>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On Tuesday 14 June 2016 12:09 PM, Heiko Stübner wrote:
> Am Montag, 13. Juni 2016, 23:31:47 schrieb weiyj_lk@163.com:
>> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>>
>> In case of error, the function devm_kzalloc() returns NULL pointer
>> not ERR_PTR(). The IS_ERR() test in the return value check should
>> be replaced with NULL test.
>>
>> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> 
> obviously correct, thanks for catching.
> 
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>

applied, thanks.

-Kishon