From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755517AbcFQOnn (ORCPT ); Fri, 17 Jun 2016 10:43:43 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:40423 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751640AbcFQOnl (ORCPT ); Fri, 17 Jun 2016 10:43:41 -0400 X-IBM-Helo: d03dlp02.boulder.ibm.com X-IBM-MailFrom: stefanb@linux.vnet.ibm.com X-IBM-RcptTo: peterhuewe@gmx.de;jarkko.sakkinen@linux.intel.com;tpmdd-devel@lists.sourceforge.net;jgunthorpe@obsidianresearch.com;tpmdd@selhorst.net;linux-kernel@vger.kernel.org;linux-security-module@vger.kernel.org Subject: Re: [PATCH 2/2] tpm_crb: fix address space of the return pointer in crb_map_res() To: Jarkko Sakkinen , Peter Huewe References: <1466174369-7140-1-git-send-email-jarkko.sakkinen@linux.intel.com> <1466174369-7140-3-git-send-email-jarkko.sakkinen@linux.intel.com> Cc: linux-security-module@vger.kernel.org, Marcel Selhorst , Jason Gunthorpe , "moderated list:TPM DEVICE DRIVER" , open list From: Stefan Berger Date: Fri, 17 Jun 2016 10:43:30 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <1466174369-7140-3-git-send-email-jarkko.sakkinen@linux.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16061714-0016-0000-0000-000003F9A358 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16061714-0017-0000-0000-0000304B8CF8 Message-Id: <57640C92.1010803@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-06-17_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1606170171 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/17/2016 10:39 AM, Jarkko Sakkinen wrote: > When running make C=2 M=drivers/char/tpm/ > > CHECK drivers/char/tpm//tpm_crb.c > drivers/char/tpm//tpm_crb.c:248:31: warning: incorrect type in return expression (different address spaces) > drivers/char/tpm//tpm_crb.c:248:31: expected void [noderef] * > drivers/char/tpm//tpm_crb.c:248:31: got void * > > Fixes: 1bd047be37d9 ("tpm_crb: Use devm_ioremap_resource") > Signed-off-by: Jarkko Sakkinen Tested-by: Stefan Berger