From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Ley Foon Tan <lftan@altera.com>,
nios2-dev@lists.rocketboards.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] nios2: time: Fix build error and warning
Date: Fri, 17 Jun 2016 19:23:05 +0200 [thread overview]
Message-ID: <576431F9.10604@linaro.org> (raw)
In-Reply-To: <1466171223-30963-1-git-send-email-linux@roeck-us.net>
On 06/17/2016 03:47 PM, Guenter Roeck wrote:
> nios2 builds fail with
>
> arch/nios2/kernel/time.c: In function 'time_init':
> arch/nios2/kernel/time.c:354:2: warning:
> 'return' with a value, in function returning void
>
> include/linux/of.h:999:2: warning:
> ISO C90 forbids mixed declarations and code
>
> include/linux/of.h:999:22: error:
> expected declaration or statement at end of input
>
> Fixes: 2ef9162920dc ("clocksource/drivers/nios2: Convert init function to return error")
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
Thanks ! I merged this fix with the commit.
-- Daniel
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
prev parent reply other threads:[~2016-06-17 17:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 13:47 [PATCH -next] nios2: time: Fix build error and warning Guenter Roeck
2016-06-17 17:23 ` Daniel Lezcano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=576431F9.10604@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=lftan@altera.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=nios2-dev@lists.rocketboards.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox