From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933813AbcFQRXM (ORCPT ); Fri, 17 Jun 2016 13:23:12 -0400 Received: from mail-wm0-f52.google.com ([74.125.82.52]:35738 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932858AbcFQRXH (ORCPT ); Fri, 17 Jun 2016 13:23:07 -0400 Subject: Re: [PATCH -next] nios2: time: Fix build error and warning To: Guenter Roeck References: <1466171223-30963-1-git-send-email-linux@roeck-us.net> Cc: Ley Foon Tan , nios2-dev@lists.rocketboards.org, linux-kernel@vger.kernel.org From: Daniel Lezcano Message-ID: <576431F9.10604@linaro.org> Date: Fri, 17 Jun 2016 19:23:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1466171223-30963-1-git-send-email-linux@roeck-us.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/17/2016 03:47 PM, Guenter Roeck wrote: > nios2 builds fail with > > arch/nios2/kernel/time.c: In function 'time_init': > arch/nios2/kernel/time.c:354:2: warning: > 'return' with a value, in function returning void > > include/linux/of.h:999:2: warning: > ISO C90 forbids mixed declarations and code > > include/linux/of.h:999:22: error: > expected declaration or statement at end of input > > Fixes: 2ef9162920dc ("clocksource/drivers/nios2: Convert init function to return error") > Cc: Daniel Lezcano > Signed-off-by: Guenter Roeck > --- Thanks ! I merged this fix with the commit. -- Daniel -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog