From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753535AbcFRB3k (ORCPT <rfc822;w@1wt.eu>);
	Fri, 17 Jun 2016 21:29:40 -0400
Received: from szxga02-in.huawei.com ([119.145.14.65]:22131 "EHLO
	szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751386AbcFRB3j (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 17 Jun 2016 21:29:39 -0400
Subject: Re: [PATCH -next] drm/hisilicon: Fix return value check in
 ade_dts_parse()
To: <weiyj_lk@163.com>, Xinliang Liu <z.liuxinliang@hisilicon.com>,
        "Xinwei Kong" <kong.kongxinwei@hisilicon.com>,
        David Airlie <airlied@linux.ie>
References: <1466188173-19776-1-git-send-email-weiyj_lk@163.com>
CC: Wei Yongjun <yongjun_wei@trendmicro.com.cn>,
        <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
From: Chen Feng <puck.chen@hisilicon.com>
Message-ID: <5764A3E5.50207@hisilicon.com>
Date: Sat, 18 Jun 2016 09:29:09 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <1466188173-19776-1-git-send-email-weiyj_lk@163.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.142.193.64]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
	refid=str=0001.0A090206.5764A3F3.002A,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
	ip=0.0.0.0,
	so=2013-06-18 04:22:30,
	dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: c2b33a612f41c715ad3ae8f56c5f0b1a
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Thanks!

On 2016/6/18 2:29, weiyj_lk@163.com wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> 
> In case of error, the function devm_clk_get() returns ERR_PTR()
> and never returns NULL. The NULL test in the return value check
> should be replaced with IS_ERR().
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

Reviewed-by: Chen Feng <puck.chen@hisilicon.com>
> ---
>  drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> index ed76baad..16834f4 100644
> --- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> +++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.c
> @@ -965,21 +965,21 @@ static int ade_dts_parse(struct platform_device *pdev, struct ade_hw_ctx *ctx)
>  	}
>  
>  	ctx->ade_core_clk = devm_clk_get(dev, "clk_ade_core");
> -	if (!ctx->ade_core_clk) {
> +	if (IS_ERR(ctx->ade_core_clk)) {
>  		DRM_ERROR("failed to parse clk ADE_CORE\n");
> -		return -ENODEV;
> +		return PTR_ERR(ctx->ade_core_clk);
>  	}
>  
>  	ctx->media_noc_clk = devm_clk_get(dev, "clk_codec_jpeg");
> -	if (!ctx->media_noc_clk) {
> +	if (IS_ERR(ctx->media_noc_clk)) {
>  		DRM_ERROR("failed to parse clk CODEC_JPEG\n");
> -	    return -ENODEV;
> +		return PTR_ERR(ctx->media_noc_clk);
>  	}
>  
>  	ctx->ade_pix_clk = devm_clk_get(dev, "clk_ade_pix");
> -	if (!ctx->ade_pix_clk) {
> +	if (IS_ERR(ctx->ade_pix_clk)) {
>  		DRM_ERROR("failed to parse clk ADE_PIX\n");
> -	    return -ENODEV;
> +		return PTR_ERR(ctx->ade_pix_clk);
>  	}
>  
>  	return 0;
> 
> 
> 
> 
> 
> 
> .
>