From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751586AbcFRPOu (ORCPT ); Sat, 18 Jun 2016 11:14:50 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:35100 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751285AbcFRPOs (ORCPT ); Sat, 18 Jun 2016 11:14:48 -0400 Subject: Re: [PATCH 0/6] dell-smm-hwmon fixes To: =?UTF-8?Q?Pali_Roh=c3=a1r?= , Jean Delvare , Jan C Peters , Thorsten Leemhuis , =?UTF-8?Q?David_Santamar=c3=ada_Rogado?= , Peter Saunderson , Tolga Cakir , "Austin S. Hemmelgarn" , Mario_Limonciello@dell.com, Gabriele Mazzotta , =?UTF-8?B?TWljaGHFgiBLxJlwaWU=?= =?UTF-8?B?xYQ=?= , Dakota Whipple , Leon Yu References: <1466204089-17030-1-git-send-email-pali.rohar@gmail.com> Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org From: Guenter Roeck Message-ID: <57656537.3020904@roeck-us.net> Date: Sat, 18 Jun 2016 08:13:59 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1466204089-17030-1-git-send-email-pali.rohar@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/17/2016 03:54 PM, Pali Rohár wrote: > I'm sending all my dell-smm-hwmon patches in one series, because due to > changes in code other patches depends on previous. > > First two patches fixes problem with old /proc/i8k file. Second is security > fix and should be backported to all stable kernels (that problem was there > always). I tested i8kctl tool (from i8kutils package) that it still works > with these patches. Without root access for those security operations just > showes '?' or '-1'. > > Third and fourth patches try to fix problem on machines with broken > SMM/BIOS when calling function fan_type(). > > Fifth is new feature and last sixth useful for debugging. > > Pali Rohár (6): > hwmon: (dell-smm) Fail in ioctl I8K_BIOS_VERSION when bios version is > not a number > hwmon: (dell-smm) Restrict fan control and serial number to > CAP_SYS_ADMIN by default > hwmon: (dell-smm) Disallow fan_type() calls on broken machines > hwmon: (dell-smm) Cache fan_type() calls and change fan detection > hwmon: (dell-smm) Detect fan with index=2 > hwmon: (dell-smm) In debug mode log duration of SMM calls > > drivers/hwmon/dell-smm-hwmon.c | 122 ++++++++++++++++++++++++++++++++-------- > 1 file changed, 99 insertions(+), 23 deletions(-) > Pali, You asked for additional testing, so I am not sure what you expect me to do. Which of the patches can/should I apply now ? Guenter