From: Guenter Roeck <linux@roeck-us.net>
To: "Andrew F. Davis" <afd@ti.com>
Cc: Jean Delvare <jdelvare@suse.com>,
Jonathan Corbet <corbet@lwn.net>,
Laxman Dewangan <ldewangan@nvidia.com>,
linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/1] hwmon: Add support for INA3221 Triple Current/Voltage Monitors
Date: Sat, 18 Jun 2016 08:16:43 -0700 [thread overview]
Message-ID: <576565DB.5040007@roeck-us.net> (raw)
In-Reply-To: <5764860E.1040305@ti.com>
Hi Andrew,
On 06/17/2016 04:21 PM, Andrew F. Davis wrote:
> On 06/10/2016 11:44 AM, Guenter Roeck wrote:
>> On Fri, Jun 10, 2016 at 10:32:33AM -0500, Andrew F. Davis wrote:
>>> Add support for the the INA3221 26v capable, Triple channel,
>>> Bi-Directional, Zero-Drift, Low-/High-Side, Current/Voltage Monitor
>>> with I2C interface.
>>>
>>> Signed-off-by: Andrew F. Davis <afd@ti.com>
>>
>> Applied to -next.
>>
>> Can you by any chance send me a register dump ? I would like to write
>> module test code for the chip.
>>
>
> No problem:
>
> # i2cdump -y 2 0x48
> No size specified (using byte-data access)
> 0 1 2 3 4 5 6 7 8 9 a b c d e f 0123456789abcdef
> 00: 18 16 80 00 08 7f 80 7f 80 00 00 00 00 00 00 00 ???.?????.......
> 10: e0 00 00 f0 00 00 03 00 00 7f 00 00 00 00 00 00 ?..?..?..?......
> 20: 7f 0a 01 00 00 XX 00 00 00 00 0e 00 00 00 40 00 ???..X....?...@.
> 30: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> 40: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> 50: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> 60: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> 70: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> 80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> 90: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> c0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> d0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> e0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> f0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 55 00 ..............U.
The chip registers are 16 bit. Can you repeat the command using the "w" option ?
Thanks,
Guenter
next prev parent reply other threads:[~2016-06-18 15:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-10 15:32 [PATCH v5 0/1] Add support for INA3221 Triple Current/Voltage Monitors Andrew F. Davis
2016-06-10 15:32 ` [PATCH v5 1/1] hwmon: " Andrew F. Davis
2016-06-10 16:44 ` Guenter Roeck
2016-06-17 23:21 ` Andrew F. Davis
2016-06-18 15:16 ` Guenter Roeck [this message]
2016-06-24 15:02 ` Andrew F. Davis
2016-06-24 16:46 ` Guenter Roeck
2016-06-24 17:30 ` Andrew F. Davis
2016-06-24 20:19 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=576565DB.5040007@roeck-us.net \
--to=linux@roeck-us.net \
--cc=afd@ti.com \
--cc=corbet@lwn.net \
--cc=jdelvare@suse.com \
--cc=ldewangan@nvidia.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox