Re: [PATCH v3 3/5] perf: script: add field 'insn_disam' to display mnemonic instructions

Adrian Hunter
2024-01-19T06:29:16Z

On 19/01/24 05:57, Changbin Du wrote:
> On Thu, Jan 18, 2024 at 09:49:41PM +0200, Adrian Hunter wrote:
>> On 18/01/24 06:12, Changbin Du wrote:
>>> In addition to the 'insn' field, this adds a new field 'insn_disam' to
>>> display mnemonic instructions instead of the raw code.
>>
>> 'disam' seems an unusual abbreviation, and the 'insn' part seems a bit
>> redundant. Could this be just 'disasm' instead of 'insn_disam'?
>
> Personally, I'd preserve the insn_ prefix. So we have two related fields 'insn'
> and 'insn_disasm'.
>

'ip', 'sym' 'dso' are all related but do not have a common prefix. Also
most of the field names lean towards abbreviation.