Re: [PATCH v3 3/5] perf: script: add field 'insn_disam' to display mnemonic instructions

Changbin Du
2024-01-19T03:57:50Z

On Thu, Jan 18, 2024 at 09:49:41PM +0200, Adrian Hunter wrote:
> On 18/01/24 06:12, Changbin Du wrote:
> > In addition to the 'insn' field, this adds a new field 'insn_disam' to
> > display mnemonic instructions instead of the raw code.
>
> 'disam' seems an unusual abbreviation, and the 'insn' part seems a bit
> redundant. Could this be just 'disasm' instead of 'insn_disam'?

Personally, I'd preserve the insn_ prefix. So we have two related fields 'insn'
and 'insn_disasm'.

--
Cheers,
Changbin Du