From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753334AbcFTHu1 (ORCPT ); Mon, 20 Jun 2016 03:50:27 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:27390 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753307AbcFTHuQ (ORCPT ); Mon, 20 Jun 2016 03:50:16 -0400 X-AuditID: cbfec7f5-f792a6d000001302-b9-5767a02c7e1c Subject: Re: [PATCH 5/6] memory: samsung/exynos-srom: make it explicitly non-modular To: Paul Gortmaker , linux-kernel@vger.kernel.org References: <20160617003748.12188-1-paul.gortmaker@windriver.com> <20160617003748.12188-6-paul.gortmaker@windriver.com> Cc: Pankaj Dubey , Kukjin Kim , linux-samsung-soc@vger.kernel.org From: Krzysztof Kozlowski Message-id: <5767A02B.4070401@samsung.com> Date: Mon, 20 Jun 2016 09:50:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-version: 1.0 In-reply-to: <20160617003748.12188-6-paul.gortmaker@windriver.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrHLMWRmVeSWpSXmKPExsVy+t/xy7o6C9LDDZYetbJ4/cLQov/xa2aL y7vmsFnMOL+PyWLR1i/sFtf2Hmd2YPPYtKqTzaNvyypGj8+b5DzWb9nKFMASxWWTkpqTWZZa pG+XwJXxb+oi9oLF3BWr385gbWBcyNnFyMkhIWAi8WXTOlYIW0ziwr31bF2MXBxCAksZJTbc mAqWEBJ4xiix+1gBiC0sECbx6OJKZhBbRMBfYvuGNewQNZUSD78fBoszC+RLHL5wig3EZhMw lti8fAmYzSugJdFwdiFYPYuAqsSshceYQGxRgQiJWdt/MEHUCEr8mHyPBcTmFHCSuLDnFZDN ATRTT+L+RS2I8fISm9e8ZZ7AKDALSccshKpZSKoWMDKvYhRNLU0uKE5KzzXSK07MLS7NS9dL zs/dxAgJ5a87GJceszrEKMDBqMTDa3E2LVyINbGsuDL3EKMEB7OSCO/jeenhQrwpiZVVqUX5 8UWlOanFhxilOViUxHln7nofIiSQnliSmp2aWpBaBJNl4uCUamDsdzpcJqPPnvCvXup9f+cU a+7UQ247pl3f/cLMWuPInABfowcT+FyqE6+v2mZuM3/Pokm3pl/6MSG8tOi02sffAfNn5XOy /btX/u+cxxdr08b53V5X23ieCAjZaGZ6BBUn3v8dKHWzNWuzxCpp67BT1YEtC4z4grctl2aQ e/fH90WnomRCla4SS3FGoqEWc1FxIgANP1g9YQIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/17/2016 02:37 AM, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > memory/samsung/Kconfig:config EXYNOS_SROM > memory/samsung/Kconfig: bool "Exynos SROM controller driver" if COMPILE_TEST > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the modular code that is essentially orphaned, so that > when reading the driver there is no doubt it is builtin-only. > > We explicitly disallow a driver unbind, since that doesn't have a > sensible use case anyway, and it allows us to drop the ".remove" > code for non-modular drivers. > > Since module_platform_driver() uses the same init level priority as > builtin_platform_driver() the init ordering remains unchanged with > this commit. > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > We also delete the MODULE_LICENSE tag etc. since all that information > is already contained at the top of the file in the comments. > > Cc: Pankaj Dubey > Cc: Kukjin Kim > Cc: Krzysztof Kozlowski > Cc: linux-samsung-soc@vger.kernel.org > Signed-off-by: Paul Gortmaker > --- > drivers/memory/samsung/exynos-srom.c | 21 +++------------------ > 1 file changed, 3 insertions(+), 18 deletions(-) Thanks, applied for v4.8. Best regards, Krzysztof