From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753441AbcFTIC0 (ORCPT ); Mon, 20 Jun 2016 04:02:26 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:60016 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752468AbcFTICI (ORCPT ); Mon, 20 Jun 2016 04:02:08 -0400 X-AuditID: cbfee68f-f79476d000001429-d5-5767a2fb669c Message-id: <5767A2FB.1040904@samsung.com> Date: Mon, 20 Jun 2016 17:02:03 +0900 From: Jaehoon Chung User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-version: 1.0 To: Enric Balletbo Serra , Enric Balletbo i Serra Cc: Ulf Hansson , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH v2 0/1] mmc: dw_mmc: Fix UHS tuning on some brand of cards. References: <1461657838-25484-1-git-send-email-enric.balletbo@collabora.com> <572079BE.9000006@samsung.com> <57207E00.8070704@collabora.com> In-reply-to: Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprIIsWRmVeSWpSXmKPExsWyRsSkQPf3ovRwgw3tEhYXfq9ks1hz+xCj xeVdc9gsjvzvZ7Q4vjbcgdVjx90ljB47Z91l97hzbQ+bx+dNcgEsUVw2Kak5mWWpRfp2CVwZ kw+fYyrYIlbRefUYWwPjC8EuRk4OCQETiZsX57BD2GISF+6tZwOxhQRWMEr8m2UOU/P94zeg OBdQfBajxKGzjxkhnAeMEruXfmcBqeIV0JJ4MPEUK4jNIqAqsenUPWYQm01AR2L7t+NMILao QJjEg3V7WSHqBSV+TL4H1MvBISKQLvGxORMkzCyQLNHx7yjYSGGBCIkr35exQ+xaySTRMfMh 2HWcAsESc96tYgPpZRZQl5gyJReiV15i85q3zCD1EgL72CXubV/KBHGPgMS3yYfAdkkIyEps OsAM8ZikxMEVN1gmMIrNQnLRLISps5BMXcDIvIpRNLUguaA4Kb3IWK84Mbe4NC9dLzk/dxMj MKZO/3vWv4Px7gHrQ4wCHIxKPLwTpNLDhVgTy4orcw8xmgIdMZFZSjQ5Hxi5eSXxhsZmRham JqbGRuaWZkrivAulfgYLCaQnlqRmp6YWpBbFF5XmpBYfYmTi4JRqYFRuje/OMl1bGWH/clq4 onkYt8r829IWwQ+zftUUfU8/4XDMaULB9/b6g0sP2EoFz3zeGvKsNNi37sPtRa8sr531nPlC ZMVuBwn5bJGMSdNSTa64bOjo27Nh56Htjdp73zYnbSy0iH87Zw3vLtNnLE4GgS4PMrbWfPL3 4F+1+DuL5Peom5Llv5VYijMSDbWYi4oTAeVOdLqkAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrPIsWRmVeSWpSXmKPExsVy+t9jQd3fi9LDDTZPEbK48Hslm8Wa24cY LS7vmsNmceR/P6PF8bXhDqweO+4uYfTYOesuu8eda3vYPD5vkgtgiWpgtMlITUxJLVJIzUvO T8nMS7dV8g6Od443NTMw1DW0tDBXUshLzE21VXLxCdB1y8wB2qukUJaYUwoUCkgsLlbSt8M0 ITTETdcCpjFC1zckCK7HyAANJKxhzJh8+BxTwRaxis6rx9gaGF8IdjFyckgImEh8//iNDcIW k7hwbz2QzcUhJDCLUeLQ2ceMEM4DRondS7+zgFTxCmhJPJh4ihXEZhFQldh06h4ziM0moCOx /dtxJhBbVCBM4sG6vawQ9YISPybfA+rl4BARSJf42JwJEmYWSJbo+HcUbKSwQITEle/L2CF2 rWSS6Jj5EOwiToFgiTnvVrGB9DILqEtMmZIL0SsvsXnNW+YJjEBXImyYhVA1C0nVAkbmVYwS qQXJBcVJ6bmGeanlesWJucWleel6yfm5mxjBkftMagfjwV3uhxgFOBiVeHgFHNLDhVgTy4or cw8xSnAwK4nwViwECvGmJFZWpRblxxeV5qQWH2I0BQbBRGYp0eR8YFLJK4k3NDYxM7I0Mje0 MDI2VxLnffx/XZiQQHpiSWp2ampBahFMHxMHp1QD44zq56t870nPnPj+/0Y+ftEr51e8tzTZ 8Mwtr3frza4DNz+du6N7JWjhhUQJi0/RpjdMA5cduHtgsczDt7ZmU9xWn5Sa9uKhhenUWK77 x24acrPV66cXinbs+/35lavQtY0MIlfufMgofRDaXatnXPFW9INDRyPzG2HG30ubltTun/Tt 37nQ9W5KLMUZiYZazEXFiQA/KFQg8gIAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Enric, On 06/20/2016 04:59 PM, Enric Balletbo Serra wrote: > Hi Jaehoon, > > 2016-04-27 10:53 GMT+02:00 Enric Balletbo i Serra > : >> >> >> On 27/04/16 10:35, Jaehoon Chung wrote: >>> On 04/26/2016 05:03 PM, Enric Balletbo i Serra wrote: >>>> Hi, >>>> >>>> I introduced the cover letter to give some background about this. >>>> >>>> I have been investigating a problem related to at least one specific sdcard when >>>> UHS-I is set. The card is not detected due the tuning phase reports a >>>> failure. Since the problem is only reproduced with a single model of a single >>>> brand of card, it is probably a card firmware issue, but the card works fine >>>> on my laptop. >>> >>> I think you have analyzed many case..of course..it was successful to switch voltage, right? >>> Maybe this patch too old..so can you remember which specific sdcard is produced? >>> >> >> Yes it was successful to switch voltage. The specific card is an UNIREX 16GB Class 10 >> SD card (Compatible with UHS-1) >> > > Any feedback for this patch? Sorry..I missed this patch..Thanks for reminding! I will check this patch as soon as possible. Best Regards, Jaehoon Chung > > >>>> >>>> The first attempt to fix this was a patch sent by Doug Anderson [1], but Alim >>>> Akhtar found that this produced randomly a hung task on Peach-pi. I can confirm >>>> that it's easy to reproduce the hung task, either, with cold boots or suspend to >>>> ram tests. >>> >>> Yep..I have already tested and checked for this. >>> >>>> >>>> I tried to fix both problems (the original issue and the one introduced by the >>>> patch) in different ways, but I ended thinking that this second proposal is the >>>> most simple that solves both issues. So let's try to fix this by handling the >>>> response CRC error slightly differently when tuning command is happening. >>>> >>>> I tested the patch on both platforms, on exynos and on rockhip. I did lots of >>>> tests and at the moment the patch seems to fix the rockchip issue and don't >>>> hung on exynos. I'll continue testing meanwhile we discuss about it. >>>> >>>> I think the patch, at least, needs the Doug's approval (as he dig into the issue >>>> before) and the Tested-by Alim. So will be good if you have a slot of time to >>>> look a bit into this. >>>> >>>> Thanks in advance. >>>> Enric >>>> >>>> [1] https://lkml.org/lkml/2015/5/18/495 >>>> >>>> Changelog since v1: >>>> - Fix the issue found by Alim with exynos letting the data transfer >>>> take place only when MMC_SEND_TUNING_BLOCK is issued. >>>> >>>> Doug Anderson (1): >>>> mmc: dw_mmc: Wait for data transfer after response errors. >>>> >>>> drivers/mmc/host/dw_mmc.c | 27 +++++++++++++++++++++++++++ >>>> 1 file changed, 27 insertions(+) >>>> >>> > > >