From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751571AbcFTIYc (ORCPT ); Mon, 20 Jun 2016 04:24:32 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:45218 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752323AbcFTIYR (ORCPT ); Mon, 20 Jun 2016 04:24:17 -0400 Subject: Re: [PATCH] ARM: AM43XX: hwmod: Fix RSTST register offset for pruss To: "Mohammed, Afzal" , "J, KEERTHY" , "tony@atomide.com" References: <1466394745-983-1-git-send-email-j-keerthy@ti.com> <5E94841CD408F1498111ED1D1196B1B237B18D3A@DBDE04.ent.ti.com> CC: "linux-omap@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Kristo, Tero" , "Gerlach, Dave" , "Anna, Suman" , "paul@pwsan.com" , "linux@armlinux.org.uk" From: Keerthy Message-ID: <5767A81E.1040809@ti.com> Date: Mon, 20 Jun 2016 13:53:58 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <5E94841CD408F1498111ED1D1196B1B237B18D3A@DBDE04.ent.ti.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 20 June 2016 12:35 PM, Mohammed, Afzal wrote: > Hi, > > J, KEERTHY wrote on Monday, June 20, 2016 9:22 AM: > >> pruss hwmod RSTST register wrongly points to PWRSTCTRL register in case of >> am43xx. Fix the RSTST register offset value. > >> This can lead to setting of wrong power state values for PER domain. > > Just curious, does it happen or noticed by going thr' the code ? No i was trying omap4_prminst_deassert_hardreset on AM43XX on my local tree and i saw issues and then saw that RSTST register offsets were wrongly populated. Hence fixing the same. > > Regards > afzal >