From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932642AbcFTMUi (ORCPT ); Mon, 20 Jun 2016 08:20:38 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:45760 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753581AbcFTMSI (ORCPT ); Mon, 20 Jun 2016 08:18:08 -0400 X-AuditID: cbfec7f5-f792a6d000001302-b5-5767defde8f9 Subject: Re: [PATCH v4 3/7] max8903: cleans up confusing relationship between dc_valid, dok and dcm. To: Chris Lapa , dwmw2@infradead.org, dbaryshkov@gmail.com, sre@kernel.org, mark.rutland@arm.com, robh+dt@kernel.org References: <1464849897-21527-3-git-send-email-chris@lapa.com.au> <1466375242-38354-1-git-send-email-chris@cpdesign.com.au> <1466375242-38354-4-git-send-email-chris@cpdesign.com.au> Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org From: Krzysztof Kozlowski X-Enigmail-Draft-Status: N1110 Message-id: <5767DEFB.8010207@samsung.com> Date: Mon, 20 Jun 2016 14:18:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-version: 1.0 In-reply-to: <1466375242-38354-4-git-send-email-chris@cpdesign.com.au> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrDLMWRmVeSWpSXmKPExsVy+t/xy7p/76WHGyx8x2jx8IyZxaQn75kt 5h85x2oxceVkZovXLwwtLu+aw2bxufcIo8XS6xeZLFr3HmG3OL27xIHLY828NYweO2fdZffY vELLY9OqTjaPZXM3M3r0bVnF6PF5k1wAexSXTUpqTmZZapG+XQJXxp5n05kK+tkquv5cYG9g /MbSxcjJISFgInFu50YoW0ziwr31bF2MXBxCAksZJQ4s6mcESQgJPGOU+DBVB8QWFkiTmDqr BaxIRKCTUeL7y+2MEB07GSUaN51lBaliFoiQ6HxwiB3EZhMwlti8fAkbxAo5id7uSWDreAW0 JLbO7ASLswioSpy7tR+sVxSod9b2H0wQNYISPybfA6vnFHCTeNkxDWgmB9B8PYn7F7UgVslL bF7zlnkCo+AsJB2zEKpmIalawMi8ilE0tTS5oDgpPddIrzgxt7g0L10vOT93EyMkTr7uYFx6 zOoQowAHoxIPr8XZtHAh1sSy4srcQ4wSHMxKIrzfbqaHC/GmJFZWpRblxxeV5qQWH2KU5mBR Eueduet9iJBAemJJanZqakFqEUyWiYNTqoHx8PNrl30ndcpzvZk058kD3WC/RRzTbrG7HM7S leR3tZzVr+ZTKXlW6t1hLsn3x6qTrhocLl9uKstqPnOiZEjOQukjHHeOt8e+C30c+eZW9sQl soL7a1PWv3WWc3G46nNjr+Jkrn+hs96skqnQnTM3yWiOr1CDco9rHhffXK9ApXXX2XhSMr2V WIozEg21mIuKEwFqqQEpjwIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/20/2016 12:27 AM, Chris Lapa wrote: > From: Chris Lapa > > The max8903_charger.h file indicated that dcm and dok were not optional > when dc_valid is set. > > It makes sense to have dok as a compulsory pin when dc_valid is given. > However dcm can be optionally wired to a fixed level especially when the > circuit is configured for dc power exclusively. > > The previous implementation already allowed for this somewhat, however no > error was given if dok wasn't given whilst dc_valid was. > > The new implementation enforces dok presence when dc_valid is given. Whilst > allowing dcm to be optional. > > Signed-off-by: Chris Lapa Reviewed-by: Krzysztof Kozlowski BR. Krzysztof