From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753814AbcFTMZN (ORCPT ); Mon, 20 Jun 2016 08:25:13 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:16844 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751936AbcFTMZI (ORCPT ); Mon, 20 Jun 2016 08:25:08 -0400 X-AuditID: cbfec7f5-f792a6d000001302-77-5767dfe63e44 Subject: Re: [PATCH v4 5/7] max8903: removes non zero validity checks on gpios. To: Chris Lapa , dwmw2@infradead.org, dbaryshkov@gmail.com, sre@kernel.org, mark.rutland@arm.com, robh+dt@kernel.org References: <1464849897-21527-3-git-send-email-chris@lapa.com.au> <1466375242-38354-1-git-send-email-chris@cpdesign.com.au> <1466375242-38354-6-git-send-email-chris@cpdesign.com.au> Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org From: Krzysztof Kozlowski Message-id: <5767DFE4.7060306@samsung.com> Date: Mon, 20 Jun 2016 14:21:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-version: 1.0 In-reply-to: <1466375242-38354-6-git-send-email-chris@cpdesign.com.au> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrHLMWRmVeSWpSXmKPExsVy+t/xa7rP7qeHGzy/z27x8IyZxaQn75kt 5h85x2oxceVkZovXLwwtLu+aw2bxufcIo8XS6xeZLFr3HmG3OL27xIHLY828NYweO2fdZffY vELLY9OqTjaPZXM3M3r0bVnF6PF5k1wAexSXTUpqTmZZapG+XQJXxqwVMgXnWCqmTvjK1MB4 h7mLkYNDQsBEovVOUBcjJ5ApJnHh3nq2LkYuDiGBpYwSTUvmQjnPGCWOfupgBKkSFvCXmDp1 IQtIQkSgk1Hi+8vtjBBVOxklLu+ZyAJSxSwQIdH54BA7iM0mYCyxefkSNhCbV0BLYsK162A2 i4CqxO65t1hBbFGg+lnbfzBB1AhK/Jh8jwXkPE4BN4lHR71ATGYBPYn7F7UgpstLbF7zlnkC o8AsJA2zEKpmIalawMi8ilE0tTS5oDgpPddIrzgxt7g0L10vOT93EyMkFr7uYFx6zOoQowAH oxIPr8XZtHAh1sSy4srcQ4wSHMxKIrwr76WHC/GmJFZWpRblxxeV5qQWH2KU5mBREueduet9 iJBAemJJanZqakFqEUyWiYNTqoHRNJCRxfPfAxPH2zKyjNOba7llalnvVF/jVzp19EHDuyPi ATfVdjienP0lkLklOkaWP2zCiy0hlZduvjm6eYZQt5G+xUrteQ8y2htSzP9rvYk1Wtb17ttD WSub2+5/Vj656Htjmtuf51d/Lp+wXijeaGeAq0WvU9DU03NrjM/G9O5P6TUrXmmqxFKckWio xVxUnAgAC3wusYECAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/20/2016 12:27 AM, Chris Lapa wrote: > From: Chris Lapa > > Prior to this commit a zero gpio was treated as invalid. Whereas > gpio_is_valid() will treat a zero gpio as valid. > > This commit removes the confusion and explicitly uses gpio_is_valid() > throughout. Which in turn results in several of the error messages becoming > redundant and thus removed. > > Signed-off-by: Chris Lapa The same as in #1, I already reviewed it. For the record: Reviewed-by: Krzysztof Kozlowski BR. Krzysztof