From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754124AbcFTQVu (ORCPT <rfc822;w@1wt.eu>);
	Mon, 20 Jun 2016 12:21:50 -0400
Received: from arroyo.ext.ti.com ([198.47.19.12]:57650 "EHLO arroyo.ext.ti.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752222AbcFTQVn (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 20 Jun 2016 12:21:43 -0400
Subject: Re: [PATCH] ARM: AM43XX: hwmod: Fix RSTST register offset for pruss
To: Keerthy <a0393675@ti.com>, "Mohammed, Afzal" <afzal@ti.com>,
        "J, KEERTHY" <j-keerthy@ti.com>, "tony@atomide.com" <tony@atomide.com>
References: <1466394745-983-1-git-send-email-j-keerthy@ti.com>
 <5E94841CD408F1498111ED1D1196B1B237B18D3A@DBDE04.ent.ti.com>
 <5767A81E.1040809@ti.com>
CC: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Kristo, Tero" <t-kristo@ti.com>, "Gerlach, Dave" <d-gerlach@ti.com>,
        "paul@pwsan.com" <paul@pwsan.com>,
        "linux@armlinux.org.uk" <linux@armlinux.org.uk>
From: Suman Anna <s-anna@ti.com>
Message-ID: <5768177B.9070306@ti.com>
Date: Mon, 20 Jun 2016 11:19:07 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.8.0
MIME-Version: 1.0
In-Reply-To: <5767A81E.1040809@ti.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Afzal,

On 06/20/2016 03:23 AM, Keerthy wrote:
> 
> 
> On Monday 20 June 2016 12:35 PM, Mohammed, Afzal wrote:
>> Hi,
>>
>> J, KEERTHY wrote on Monday, June 20, 2016 9:22 AM:
>>
>>> pruss hwmod RSTST register wrongly points to PWRSTCTRL register in
>>> case of
>>> am43xx. Fix the RSTST register offset value.
>>
>>> This can lead to setting of wrong power state values for PER domain.
>>
>> Just curious, does it happen or noticed by going thr' the code ?

It does happen when the pruss module is exercised. We found this when we
tried to do a standby test on suspend, and while it worked on AM33xx,
AM437x failed because of this difference.

regards
Suman

> 
> No i was trying omap4_prminst_deassert_hardreset on AM43XX on my local
> tree and i saw issues and then saw that RSTST register offsets were
> wrongly populated. Hence fixing the same.
> 
>>
>> Regards
>> afzal
>>