From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755087AbcFTQqs (ORCPT <rfc822;w@1wt.eu>);
	Mon, 20 Jun 2016 12:46:48 -0400
Received: from avon.wwwdotorg.org ([70.85.31.133]:50310 "EHLO
	avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752924AbcFTQqk (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 20 Jun 2016 12:46:40 -0400
Subject: Re: [PATCH v2] arm: tegra124: remove commas from unit addresses
To: Thierry Reding <thierry.reding@gmail.com>
References: <1466298275-15753-1-git-send-email-marcel.ziswiler@toradex.com>
 <576810C2.1030401@wwwdotorg.org> <20160620164057.GD6175@ulmo.ba.sec>
Cc: Marcel Ziswiler <marcel.ziswiler@toradex.com>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
        linux-tegra@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>,
        Alexandre Courbot <gnurou@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        linux-arm-kernel@lists.infradead.org
From: Stephen Warren <swarren@wwwdotorg.org>
Message-ID: <57681DC3.9090801@wwwdotorg.org>
Date: Mon, 20 Jun 2016 10:45:55 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.8.0
MIME-Version: 1.0
In-Reply-To: <20160620164057.GD6175@ulmo.ba.sec>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 06/20/2016 10:40 AM, Thierry Reding wrote:
> On Mon, Jun 20, 2016 at 09:50:26AM -0600, Stephen Warren wrote:
>> On 06/18/2016 07:04 PM, Marcel Ziswiler wrote:
>>> Remove commas from unit addresses as suggested by Rob Herring upon me
>>> posting initial Apalis TK1 support:
>>>
>>> http://article.gmane.org/gmane.linux.ports.tegra/26608
>>
>> Acked-by: Stephen Warren <swarren@nvidia.com>
>
> I'm confused now. I posted almost exactly the same patch a while ago and
> we agreed that we couldn't do this because the node names were to be
> considered part of the ABI.
>
> Is it or is it not?

The particular case where it matters is the GPU node, which U-Boot 
manipulates. This revised patch version no longer renames the GPU node 
and so in practice avoids any issues that I'm aware of.

If there's a more general rule that node names are part of the ABI, then 
indeed we shouldn't take this patch.